Mercurial > p > roundup > code
view test/test_locking.py @ 8533:67ed90055e47
test: handle failing email signature removal test differently
The comment for the test is:
# This fails because the sig isn't removed (we currently remove the
# sig only if the delimiter is the first line in a section)
Originally the test was decorated so it didn't run at all and reported
PASSED. The decorator also returned the value 0. This caused a
deprecation warning:
test/test_mailgw.py::MailgwTestCase::testEmailQuotingRemove3
/usr/lib/python3.12/unittest/case.py:690: DeprecationWarning: It is
deprecated to return a value that is not None from a test case [...]
Better to handle it using pytest xfail so if we start stripping the
signature we get a failure.
This does mean the tests get an xfail registered, but I am ok with
that. I added "OK" to the reason to indicate it was expected.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 18 Mar 2026 11:11:03 -0400 |
| parents | fed0f839c260 |
| children |
line wrap: on
line source
# Copyright (c) 2002 ekit.com Inc (http://www.ekit-inc.com/) # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal # in the Software without restriction, including without limitation the rights # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell # copies of the Software, and to permit persons to whom the Software is # furnished to do so, subject to the following conditions: # # The above copyright notice and this permission notice shall be included in # all copies or substantial portions of the Software. # # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE # SOFTWARE. import os, unittest, tempfile from roundup.backends.locking import acquire_lock, release_lock class LockingTest(unittest.TestCase): def setUp(self): self.path = tempfile.mktemp() open(self.path, 'w').write('hi\n') # XXX test disabled because it simply doesn't work on many platforms # (Solaris and Irix are known to fail, but Linux works) def xtest_basics(self): f = acquire_lock(self.path) try: acquire_lock(self.path, block=0) except Exception: pass else: raise AssertionError('no exception') release_lock(f) f = acquire_lock(self.path) release_lock(f) def tearDown(self): os.remove(self.path) # vim: set filetype=python ts=4 sw=4 et si
