Mercurial > p > roundup > code
view test/test_instance.py @ 8533:67ed90055e47
test: handle failing email signature removal test differently
The comment for the test is:
# This fails because the sig isn't removed (we currently remove the
# sig only if the delimiter is the first line in a section)
Originally the test was decorated so it didn't run at all and reported
PASSED. The decorator also returned the value 0. This caused a
deprecation warning:
test/test_mailgw.py::MailgwTestCase::testEmailQuotingRemove3
/usr/lib/python3.12/unittest/case.py:690: DeprecationWarning: It is
deprecated to return a value that is not None from a test case [...]
Better to handle it using pytest xfail so if we start stripping the
signature we get a failure.
This does mean the tests get an xfail registered, but I am ok with
that. I added "OK" to the reason to indicate it was expected.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 18 Mar 2026 11:11:03 -0400 |
| parents | 778a9f455067 |
| children | 9c3ec0a5c7fc |
line wrap: on
line source
# # Copyright (C) 2020 John Rouillard # All rights reserved. # For license terms see the file COPYING.txt. # from __future__ import print_function import unittest, os, shutil, errno, sys, difflib from roundup import instance from roundup.instance import TrackerError try: # python2 import pathlib2 as pathlib except ImportError: # python3 import pathlib from . import db_test_base class InstanceTest(unittest.TestCase): backend = 'anydbm' def setUp(self): self.dirname = '_test_instance' # set up and open a tracker self.instance = db_test_base.setupTracker(self.dirname, self.backend) # open the database self.db = self.instance.open('admin') self.db.commit() self.db.close() def tearDown(self): if self.db: self.db.close() try: shutil.rmtree(self.dirname) except OSError as error: if error.errno not in (errno.ENOENT, errno.ESRCH): raise def testOpenOldStyle(self): pathlib.Path(os.path.join(self.dirname, "dbinit.py")).touch() # no longer support old style tracker configs self.assertRaises(TrackerError, instance.open, self.dirname)
