Mercurial > p > roundup > code
view test/conftest.py @ 8533:67ed90055e47
test: handle failing email signature removal test differently
The comment for the test is:
# This fails because the sig isn't removed (we currently remove the
# sig only if the delimiter is the first line in a section)
Originally the test was decorated so it didn't run at all and reported
PASSED. The decorator also returned the value 0. This caused a
deprecation warning:
test/test_mailgw.py::MailgwTestCase::testEmailQuotingRemove3
/usr/lib/python3.12/unittest/case.py:690: DeprecationWarning: It is
deprecated to return a value that is not None from a test case [...]
Better to handle it using pytest xfail so if we start stripping the
signature we get a failure.
This does mean the tests get an xfail registered, but I am ok with
that. I added "OK" to the reason to indicate it was expected.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 18 Mar 2026 11:11:03 -0400 |
| parents | 43dc610bbd24 |
| children |
line wrap: on
line source
# simple way to see if there are order dependencies in tests # can use if pytest-random-order --random-order mode isn't # usable (e.g. python2). # known issues: # python3 -m pytest -k Whoosh test/test_indexer.py fails starting with # first reversed (so last) test in module # # python3 -m pytest test/test_cgi.py # fails: FormTestCase::testCreatePermission # FormTestCase::testClassPermission # FormTestCase::testCheckAndPropertyPermission # # this failure results in a failure in test_action again with # bad permission application. Something run prior to these # tests is breaking the permission checks. #def pytest_collection_modifyitems(items): # items.reverse() # Add a marker for pg_schema tests. # They duplicate the postgresql tests exactly but uses a named # schema rather than the default 'public' schema. def pytest_configure(config): config.addinivalue_line( "markers", "pg_schema: tests using schema for postgres" ) # try to work around loss of testmon data when ^Cing out of tests. def pytest_unconfigure(config): if hasattr(config, "testmon_data"): config.testmon_data.db.con.close()
