Mercurial > p > roundup > code
view test/test_security.py @ 5232:462b0f76fce8
issue2550864 - Potential information leakage via journal/history
Fix this by making the hyperdb::Class::history function check for view
permissions on the journaled properties. So a user that sees [hidden]
for a property in the web interface doesn;t see the property changes
in the history.
While doing this, relocated the filter for quiet properties
from the templating class to the hyperdb.
Also added the skipquiet option to the history command in
roundup-admin.py to enable filtering of quiet params.
Also changed calls to history() in the backend databases to report all
items.
Changed inline documentation for all history calls that document the
actions. The create action (before nov 6 2002) used to record all
parameters. After that point the create call uses an empty dictionary.
The filtering code depends on the create dictionary being empty.
It may not operate properly on very old roundup databases.
Changed calls to logging.getLogger to roundup.hyperdb.backends to
allow filtering the back end while keeping hyperdb logging.
In cgi/templating.py, changed history() function consolidating
handiling of link and unlink actions
Added tests for quiet property filtering and permission filtering
of history.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Fri, 14 Apr 2017 23:24:18 -0400 |
| parents | 16a8a3f0772c |
| children | c94fd717e28c |
line wrap: on
line source
# Copyright (c) 2002 ekit.com Inc (http://www.ekit-inc.com/) # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal # in the Software without restriction, including without limitation the rights # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell # copies of the Software, and to permit persons to whom the Software is # furnished to do so, subject to the following conditions: # # The above copyright notice and this permission notice shall be included in # all copies or substantial portions of the Software. # # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE # SOFTWARE. import os, unittest, shutil from roundup import backends import roundup.password from db_test_base import setupSchema, MyTestCase, config class PermissionTest(MyTestCase, unittest.TestCase): def setUp(self): backend = backends.get_backend('anydbm') # remove previous test, ignore errors if os.path.exists(config.DATABASE): shutil.rmtree(config.DATABASE) os.makedirs(config.DATABASE + '/files') self.db = backend.Database(config, 'admin') setupSchema(self.db, 1, backend) def testInterfaceSecurity(self): ' test that the CGI and mailgw have initialised security OK ' # TODO: some asserts def testInitialiseSecurity(self): ei = self.db.security.addPermission(name="Edit", klass="issue", description="User is allowed to edit issues") self.db.security.addPermissionToRole('User', ei) ai = self.db.security.addPermission(name="View", klass="issue", description="User is allowed to access issues") self.db.security.addPermissionToRole('User', ai) def testAdmin(self): ei = self.db.security.addPermission(name="Edit", klass="issue", description="User is allowed to edit issues") self.db.security.addPermissionToRole('User', ei) ei = self.db.security.addPermission(name="Edit", klass=None, description="User is allowed to edit issues") self.db.security.addPermissionToRole('Admin', ei) u1 = self.db.user.create(username='one', roles='Admin') u2 = self.db.user.create(username='two', roles='User') self.assert_(self.db.security.hasPermission('Edit', u1, None)) self.assert_(not self.db.security.hasPermission('Edit', u2, None)) def testGetPermission(self): self.db.security.getPermission('Edit') self.db.security.getPermission('View') self.assertRaises(ValueError, self.db.security.getPermission, 'x') self.assertRaises(ValueError, self.db.security.getPermission, 'Edit', 'fubar') add = self.db.security.addPermission get = self.db.security.getPermission # class ei = add(name="Edit", klass="issue") self.assertEquals(get('Edit', 'issue'), ei) ai = add(name="View", klass="issue") self.assertEquals(get('View', 'issue'), ai) # property epi1 = add(name="Edit", klass="issue", properties=['title']) self.assertEquals(get('Edit', 'issue', properties=['title']), epi1) epi2 = add(name="Edit", klass="issue", properties=['title'], props_only=True) self.assertEquals(get('Edit', 'issue', properties=['title'], props_only=False), epi1) self.assertEquals(get('Edit', 'issue', properties=['title'], props_only=True), epi2) self.db.security.set_props_only_default(True) self.assertEquals(get('Edit', 'issue', properties=['title']), epi2) api1 = add(name="View", klass="issue", properties=['title']) self.assertEquals(get('View', 'issue', properties=['title']), api1) self.db.security.set_props_only_default(False) api2 = add(name="View", klass="issue", properties=['title']) self.assertEquals(get('View', 'issue', properties=['title']), api2) self.assertNotEquals(get('View', 'issue', properties=['title']), api1) # check function dummy = lambda: 0 eci = add(name="Edit", klass="issue", check=dummy) self.assertEquals(get('Edit', 'issue', check=dummy), eci) # props_only only makes sense if you are setting props. # make it a no-op unless properties is set. self.assertEquals(get('Edit', 'issue', check=dummy, props_only=True), eci) aci = add(name="View", klass="issue", check=dummy) self.assertEquals(get('View', 'issue', check=dummy), aci) # all epci = add(name="Edit", klass="issue", properties=['title'], check=dummy) self.db.security.set_props_only_default(False) # implicit props_only=False self.assertEquals(get('Edit', 'issue', properties=['title'], check=dummy), epci) # explicit props_only=False self.assertEquals(get('Edit', 'issue', properties=['title'], check=dummy, props_only=False), epci) # implicit props_only=True self.db.security.set_props_only_default(True) self.assertRaises(ValueError, get, 'Edit', 'issue', properties=['title'], check=dummy) # explicit props_only=False self.assertRaises(ValueError, get, 'Edit', 'issue', properties=['title'], check=dummy, props_only=True) apci = add(name="View", klass="issue", properties=['title'], check=dummy) self.assertEquals(get('View', 'issue', properties=['title'], check=dummy), apci) # Reset to default. Somehow this setting looks like it # was bleeding through to other tests in test_xmlrpc. # Is the security module being loaded only once for all tests?? self.db.security.set_props_only_default(False) def testDBinit(self): self.db.user.create(username="demo", roles='User') self.db.user.create(username="anonymous", roles='Anonymous') def testAccessControls(self): add = self.db.security.addPermission has = self.db.security.hasPermission addRole = self.db.security.addRole addToRole = self.db.security.addPermissionToRole none = self.db.user.create(username='none', roles='None') # test admin access addRole(name='Super') addToRole('Super', add(name="Test")) super = self.db.user.create(username='super', roles='Super') # test class-level access addRole(name='Role1') addToRole('Role1', add(name="Test", klass="test")) user1 = self.db.user.create(username='user1', roles='Role1') self.assertEquals(has('Test', user1, 'test'), 1) self.assertEquals(has('Test', super, 'test'), 1) self.assertEquals(has('Test', none, 'test'), 0) # property addRole(name='Role2') addToRole('Role2', add(name="Test", klass="test", properties=['a','b'])) user2 = self.db.user.create(username='user2', roles='Role2') # check function check_old_style = lambda db, userid, itemid: itemid == '2' #def check_old_style(db, userid, itemid): # print "checking userid, itemid: %r"%((userid,itemid),) # return(itemid == '2') # setup to check function new style. Make sure that # other args are passed. def check(db,userid,itemid, **other): prop = other['property'] prop = other['classname'] prop = other['permission'] return (itemid == '1') addRole(name='Role3') addToRole('Role3', add(name="Test", klass="test", check=check)) user3 = self.db.user.create(username='user3', roles='Role3') addRole(name='Role4') addToRole('Role4', add(name="Test", klass="test", check=check, properties='a', props_only=True)) user4 = self.db.user.create(username='user4', roles='Role4') self.db.security.set_props_only_default(props_only=True) addRole(name='Role5') addToRole('Role5', add(name="Test", klass="test", check=check_old_style, properties=['a'])) user5 = self.db.user.create(username='user5', roles='Role5') self.db.security.set_props_only_default(False) addRole(name='Role6') addToRole('Role6', add(name="Test", klass="test", check=check, properties=['a', 'b'])) user6 = self.db.user.create(username='user6', roles='Role6') addRole(name='Role7') addToRole('Role7', add(name="Test", klass="test", check=check_old_style, properties=['a', 'b'])) user7 = self.db.user.create(username='user7', roles='Role7') print user7 # *any* access to class self.assertEquals(has('Test', user1, 'test'), 1) self.assertEquals(has('Test', user2, 'test'), 1) self.assertEquals(has('Test', user3, 'test'), 1) # user4 and user5 should not return true as the permission # is limited to property checks self.assertEquals(has('Test', user4, 'test'), 0) self.assertEquals(has('Test', user5, 'test'), 0) # user6 will will return access self.assertEquals(has('Test', user6, 'test'), 1) # will work because check is ignored, if check was # used this would work but next test would fail self.assertEquals(has('Test', user7, 'test', itemid='2'), 1) # returns true because class tests ignore the check command # if there is no itemid no check command is run self.assertEquals(has('Test', user7, 'test'), 1) self.assertEquals(has('Test', none, 'test'), 0) # *any* access to item self.assertEquals(has('Test', user1, 'test', itemid='1'), 1) self.assertEquals(has('Test', user2, 'test', itemid='1'), 1) self.assertEquals(has('Test', user3, 'test', itemid='1'), 1) self.assertEquals(has('Test', user4, 'test', itemid='1'), 0) self.assertEquals(has('Test', user5, 'test', itemid='1'), 0) self.assertEquals(has('Test', user6, 'test', itemid='1'), 1) self.assertEquals(has('Test', user7, 'test', itemid='2'), 1) self.assertEquals(has('Test', user7, 'test', itemid='1'), 0) self.assertEquals(has('Test', super, 'test', itemid='1'), 1) self.assertEquals(has('Test', none, 'test', itemid='1'), 0) # now property test: no default itemid so check functions not run. self.assertEquals(has('Test', user7, 'test', property='a'), 1) self.assertEquals(has('Test', user7, 'test', property='b'), 1) self.assertEquals(has('Test', user7, 'test', property='c'), 0) self.assertEquals(has('Test', user6, 'test', property='a'), 1) self.assertEquals(has('Test', user6, 'test', property='b'), 1) self.assertEquals(has('Test', user6, 'test', property='c'), 0) self.assertEquals(has('Test', user5, 'test', property='a'), 1) self.assertEquals(has('Test', user5, 'test', property='b'), 0) self.assertEquals(has('Test', user5, 'test', property='c'), 0) self.assertEquals(has('Test', user4, 'test', property='a'), 1) self.assertEquals(has('Test', user4, 'test', property='b'), 0) self.assertEquals(has('Test', user4, 'test', property='c'), 0) self.assertEquals(has('Test', user3, 'test', property='a'), 1) self.assertEquals(has('Test', user3, 'test', property='b'), 1) self.assertEquals(has('Test', user3, 'test', property='c'), 1) self.assertEquals(has('Test', user2, 'test', property='a'), 1) self.assertEquals(has('Test', user2, 'test', property='b'), 1) self.assertEquals(has('Test', user2, 'test', property='c'), 0) self.assertEquals(has('Test', user1, 'test', property='a'), 1) self.assertEquals(has('Test', user1, 'test', property='b'), 1) self.assertEquals(has('Test', user1, 'test', property='c'), 1) self.assertEquals(has('Test', super, 'test', property='a'), 1) self.assertEquals(has('Test', super, 'test', property='b'), 1) self.assertEquals(has('Test', super, 'test', property='c'), 1) self.assertEquals(has('Test', none, 'test', property='a'), 0) self.assertEquals(has('Test', none, 'test', property='b'), 0) self.assertEquals(has('Test', none, 'test', property='c'), 0) self.assertEquals(has('Test', none, 'test'), 0) # now check function self.assertEquals(has('Test', user7, 'test', itemid='1'), 0) self.assertEquals(has('Test', user7, 'test', itemid='2'), 1) self.assertEquals(has('Test', user6, 'test', itemid='1'), 1) self.assertEquals(has('Test', user6, 'test', itemid='2'), 0) # check functions will not run for user4/user5 since the # only perms are for properties only. self.assertEquals(has('Test', user5, 'test', itemid='1'), 0) self.assertEquals(has('Test', user5, 'test', itemid='2'), 0) self.assertEquals(has('Test', user4, 'test', itemid='1'), 0) self.assertEquals(has('Test', user4, 'test', itemid='2'), 0) self.assertEquals(has('Test', user3, 'test', itemid='1'), 1) self.assertEquals(has('Test', user3, 'test', itemid='2'), 0) self.assertEquals(has('Test', user2, 'test', itemid='1'), 1) self.assertEquals(has('Test', user2, 'test', itemid='2'), 1) self.assertEquals(has('Test', user1, 'test', itemid='2'), 1) self.assertEquals(has('Test', user1, 'test', itemid='2'), 1) self.assertEquals(has('Test', super, 'test', itemid='1'), 1) self.assertEquals(has('Test', super, 'test', itemid='2'), 1) self.assertEquals(has('Test', none, 'test', itemid='1'), 0) self.assertEquals(has('Test', none, 'test', itemid='2'), 0) # now mix property and check commands # check is old style props_only = false self.assertEquals(has('Test', user7, 'test', property="c", itemid='2'), 0) self.assertEquals(has('Test', user7, 'test', property="c", itemid='1'), 0) self.assertEquals(has('Test', user7, 'test', property="a", itemid='2'), 1) self.assertEquals(has('Test', user7, 'test', property="a", itemid='1'), 0) # check is new style props_only = false self.assertEquals(has('Test', user6, 'test', itemid='2', property='c'), 0) self.assertEquals(has('Test', user6, 'test', itemid='1', property='c'), 0) self.assertEquals(has('Test', user6, 'test', itemid='2', property='b'), 0) self.assertEquals(has('Test', user6, 'test', itemid='1', property='b'), 1) self.assertEquals(has('Test', user6, 'test', itemid='2', property='a'), 0) self.assertEquals(has('Test', user6, 'test', itemid='1', property='a'), 1) # check is old style props_only = true self.assertEquals(has('Test', user5, 'test', itemid='2', property='b'), 0) self.assertEquals(has('Test', user5, 'test', itemid='1', property='b'), 0) self.assertEquals(has('Test', user5, 'test', itemid='2', property='a'), 1) self.assertEquals(has('Test', user5, 'test', itemid='1', property='a'), 0) # check is new style props_only = true self.assertEquals(has('Test', user4, 'test', itemid='2', property='b'), 0) self.assertEquals(has('Test', user4, 'test', itemid='1', property='b'), 0) self.assertEquals(has('Test', user4, 'test', itemid='2', property='a'), 0) self.assertEquals(has('Test', user4, 'test', itemid='1', property='a'), 1) def testTransitiveSearchPermissions(self): add = self.db.security.addPermission has = self.db.security.hasSearchPermission addRole = self.db.security.addRole addToRole = self.db.security.addPermissionToRole addRole(name='User') addRole(name='Anonymous') addRole(name='Issue') addRole(name='Msg') addRole(name='UV') user = self.db.user.create(username='user1', roles='User') anon = self.db.user.create(username='anonymous', roles='Anonymous') ui = self.db.user.create(username='user2', roles='Issue') uim = self.db.user.create(username='user3', roles='Issue,Msg') uimu = self.db.user.create(username='user4', roles='Issue,Msg,UV') iv = add(name="View", klass="issue") addToRole('User', iv) addToRole('Anonymous', iv) addToRole('Issue', iv) ms = add(name="Search", klass="msg") addToRole('User', ms) addToRole('Anonymous', ms) addToRole('Msg', ms) uv = add(name="View", klass="user") addToRole('User', uv) addToRole('UV', uv) self.assertEquals(has(anon, 'issue', 'messages'), 1) self.assertEquals(has(anon, 'issue', 'messages.author'), 0) self.assertEquals(has(anon, 'issue', 'messages.author.username'), 0) self.assertEquals(has(anon, 'issue', 'messages.recipients'), 0) self.assertEquals(has(anon, 'issue', 'messages.recipients.username'), 0) self.assertEquals(has(user, 'issue', 'messages'), 1) self.assertEquals(has(user, 'issue', 'messages.author'), 1) self.assertEquals(has(user, 'issue', 'messages.author.username'), 1) self.assertEquals(has(user, 'issue', 'messages.recipients'), 1) self.assertEquals(has(user, 'issue', 'messages.recipients.username'), 1) self.assertEquals(has(ui, 'issue', 'messages'), 0) self.assertEquals(has(ui, 'issue', 'messages.author'), 0) self.assertEquals(has(ui, 'issue', 'messages.author.username'), 0) self.assertEquals(has(ui, 'issue', 'messages.recipients'), 0) self.assertEquals(has(ui, 'issue', 'messages.recipients.username'), 0) self.assertEquals(has(uim, 'issue', 'messages'), 1) self.assertEquals(has(uim, 'issue', 'messages.author'), 0) self.assertEquals(has(uim, 'issue', 'messages.author.username'), 0) self.assertEquals(has(uim, 'issue', 'messages.recipients'), 0) self.assertEquals(has(uim, 'issue', 'messages.recipients.username'), 0) self.assertEquals(has(uimu, 'issue', 'messages'), 1) self.assertEquals(has(uimu, 'issue', 'messages.author'), 1) self.assertEquals(has(uimu, 'issue', 'messages.author.username'), 1) self.assertEquals(has(uimu, 'issue', 'messages.recipients'), 1) self.assertEquals(has(uimu, 'issue', 'messages.recipients.username'), 1) # roundup.password has its own built-in test, call it. def test_password(self): roundup.password.test() # vim: set filetype=python sts=4 sw=4 et si :
