view scripts/add-issue @ 5414:3fa026621f69

Python 3 preparation: comparisons. Python 3 no longer has the cmp function, or cmp= arguments to sorting functions / methods (key= must be used instead), and requires rich comparison methods such as __lt__ to be defined instead of using __cmp__. All of the comparison mechanisms supported in Python 3 are also supported in Python 2. This patch makes the corresponding changes in Roundup to use key functions and rich comparison methods. In the case of the JournalPassword and Permission classes, only __eq__ and __ne__ are defined as I don't see ordered comparisons as useful there (and for Permission, the old __cmp__ function didn't try to provide a valid ordering). In the case of the Date class, I kept the __cmp__ method and implemented the others in terms of it, to avoid excess repetitiveness in duplicating implementation code for all six rich comparison methods. In roundup/admin.py, help_commands_html used operator.attrgetter to produce the second argument of sorted() - which would be reasonable for a key function, but the second argument is the cmp function in Python 2, not a key function (and the key function must be a named argument not a positional argument in Python 3). That function appears to be completely unused, so I expect that code never worked. This patch adds the missing key= to that sorted() call, but it would also be reasonable to remove the unused function completely instead.
author Joseph Myers <jsm@polyomino.org.uk>
date Wed, 25 Jul 2018 00:39:37 +0000
parents c75defc1c2f0
children 9c3ec0a5c7fc
line wrap: on
line source

#! /usr/bin/env python
'''
Usage: %s <tracker home> <priority> <issue title>

Create a new issue in the given tracker. Input is taken from STDIN to
create the initial issue message (which may be empty). Issues will be
created as the current user (%s) if they exist as a Roundup
user, or "admin" otherwise.
'''

from __future__ import print_function
import sys, os, pwd

from roundup import instance, mailgw, date

# open the instance
username = pwd.getpwuid(os.getuid())[0]
if len(sys.argv) < 3:
    print("Error: Not enough arguments")
    print(__doc__.strip()%(sys.argv[0], username))
    sys.exit(1)
tracker_home = sys.argv[1]
issue_priority = sys.argv[2]
issue_title = ' '.join(sys.argv[3:])

# get the message, if any
message_text = sys.stdin.read().strip()

# open the tracker
tracker = instance.open(tracker_home)
db = tracker.open('admin')
db.tx_Source = "cli"
uid = db.user.lookup('admin')
try:
    # try to open the tracker as the current user
    uid = db.user.lookup(username)
    db.close()
    db = tracker.open(username)
except KeyError:
    pass

try:

    # handle the message
    messages = []
    if message_text:
        summary, x = mailgw.parseContent(message_text, 0, 0)
        msg = db.msg.create(content=message_text, summary=summary, author=uid,
            date=date.Date())
        messages = [msg]

    # now create the issue
    db.issue.create(title=issue_title, priority=issue_priority,
        messages=messages)

    db.commit()
finally:
    db.close()

# vim: set filetype=python ts=4 sw=4 et si

Roundup Issue Tracker: http://roundup-tracker.org/