Mercurial > p > roundup > code
view website/issues/html/keyword.index.html @ 5988:39b8bc511ed7
Fix html generation errors for boolean options.
Code was generating xhtml form for html4 output.
In xhtml, Boolean attributes like 'disabled', 'required' are
represented with a value that is the same as the attribute name. E.G.
<input required="required" ...>. Html 5 (and 4) represents the same as
<input required ...> .
Recognize booleans in one of two ways:
value is None
value is the same as the attribute name
Make html4 and xhtml variants of cgi_escape_attrs. Have input_htmlp4
and input_xhtml call the proper variant. Also set HTMLInputMixin
property cgi_escape_atrs to select proper one similar to self.input
definition. Then replace calls to cgi_escape_attr with
self.cgi_escape_attrs to get correct output.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 14 Dec 2019 16:18:15 -0500 |
| parents | 447a7647f237 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" > <span tal:omit-tag="true" i18n:translate="" >List of keywords</span> <span tal:condition="request/dispname" tal:replace="python:' - %s '%request.dispname" /> - <span tal:replace="config/TRACKER_NAME" /> </title> <span metal:fill-slot="body_title" tal:omit-tag="true"> <span tal:omit-tag="true" i18n:translate="" >List of keywords</span> <span tal:condition="request/dispname" tal:replace="python:' - %s' % request.dispname" /> </span> <tal:block metal:fill-slot="content"> <p tal:condition="python:not (context.is_view_ok() or request.user.hasRole('Anonymous'))" i18n:translate=""> You are not allowed to view this page.</p> <p tal:condition="python:not context.is_view_ok() and request.user.hasRole('Anonymous')" i18n:translate=""> Please login with your username and password.</p> <table width="100%" tal:condition="context/is_view_ok" class="list"> <tr> <th i18n:translate="">Keyword</th> <th i18n:translate="">Description</th> </tr> <tal:block repeat="keyword context/list"> <tr tal:attributes="class python:['normal', 'alt'][repeat['keyword'].index%6//3]"> <td> <a tal:attributes="href string:keyword${keyword/id}" tal:content="keyword/name">keyword name</a> </td> <td tal:content="python:keyword.description.plain() or default"> </td> </tr> </tal:block> <tr tal:condition="context/is_edit_ok"> <td colspan="2"><a href="keyword?@template=item">New Keyword</a></td> </tr> </table> </tal:block> </tal:block>