Mercurial > p > roundup > code
view website/issues/html/file.index.html @ 5988:39b8bc511ed7
Fix html generation errors for boolean options.
Code was generating xhtml form for html4 output.
In xhtml, Boolean attributes like 'disabled', 'required' are
represented with a value that is the same as the attribute name. E.G.
<input required="required" ...>. Html 5 (and 4) represents the same as
<input required ...> .
Recognize booleans in one of two ways:
value is None
value is the same as the attribute name
Make html4 and xhtml variants of cgi_escape_attrs. Have input_htmlp4
and input_xhtml call the proper variant. Also set HTMLInputMixin
property cgi_escape_atrs to select proper one similar to self.input
definition. Then replace calls to cgi_escape_attr with
self.cgi_escape_attrs to get correct output.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 14 Dec 2019 16:18:15 -0500 |
| parents | 447a7647f237 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="" >List of files - <span tal:replace="config/TRACKER_NAME" i18n:name="tracker" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">List of files</span> <td class="content" metal:fill-slot="content"> <table class="otherinfo" tal:define="batch request/batch"> <tr><th style="padding-right: 10" i18n:translate="">Download</th> <th style="padding-right: 10" i18n:translate="">Description</th> <th style="padding-right: 10" i18n:translate="">Content Type</th> <th style="padding-right: 10" i18n:translate="">Uploaded By</th> <th style="padding-right: 10" i18n:translate="">Date</th> </tr> <tr tal:repeat="file batch" tal:attributes="class python:['normal', 'alt'][repeat['file'].index%6//3]"> <td> <a tal:attributes="href string:file${file/id}/${file/name}" tal:content="file/name">dld link</a> </td> <td tal:content="file/description">description</td> <td tal:content="file/type">content type</td> <td tal:content="file/creator">creator's name</td> <td tal:content="file/creation">creation date</td> </tr> <metal:block use-macro="templates/issue.index/macros/batch-footer" /> </table> </td> </tal:block>