view test/test_token.py @ 8265:35beff316883

fix(api): issue2551384. Verify REST authorization earlier To reduce the ability of bad actors to spam (DOS) the REST endpoint with bad data and generate logs meant for debugging, modify the flow in client.py's REST handler to verify authorization earlier. If the anonymous user is allowed to use REST, this won't make a difference for a DOS attempt. The templates don't enable REST for the anonymous user by default. Most admins don't change this. The validation order for REST requests has been changed. CORS identfied an handled User authorization to use REST (return 403 on failure) REST request validated (Origin header valid etc.) (return 400 for bad request) Incorrectly formatted CORS preflight requests (e.g. missing Origin header) that are not recogized as a CORS request can now return HTTP status 403 as well as status 400 (when anonymous is allowed access). Note all CORS preflights are sent without authentication so appear as anonymous requests. The tests were updated to compensate, but it is not obvious to me from specs what the proper evaulation order/return codes should be for this case. Both 403/400 are failures and cause CORS to fail so there should be no difference but...
author John Rouillard <rouilj@ieee.org>
date Thu, 09 Jan 2025 09:30:08 -0500
parents 9a74dfeb8620
children
line wrap: on
line source

#
# Copyright (c) 2001 Richard Jones
# This module is free software, and you may redistribute it and/or modify
# under the same terms as Python, so long as this copyright message and
# disclaimer are retained in their original form.
#
# This module is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

import unittest, time

from roundup.token_r import token_split

class TokenTestCase(unittest.TestCase):
    def testValid(self):
        l = token_split('hello world')
        self.assertEqual(l, ['hello', 'world'])

    def testIgnoreExtraSpace(self):
        l = token_split('hello  world ')
        self.assertEqual(l, ['hello', 'world'])

    def testQuoting(self):
        l = token_split('"hello world"')
        self.assertEqual(l, ['hello world'])
        l = token_split("'hello world'")
        self.assertEqual(l, ['hello world'])

    def testEmbedQuote(self):
        l = token_split(r'Roch\'e Compaan')
        self.assertEqual(l, ["Roch'e", "Compaan"])
        l = token_split('address="1 2 3"')
        self.assertEqual(l, ['address=1 2 3'])

    def testEmbedEscapeQuote(self):
        l = token_split(r'"Roch\'e Compaan"')
        self.assertEqual(l, ["Roch'e Compaan"])

        l = token_split(r'"Roch\"e Compaan"')
        self.assertEqual(l, ['Roch"e Compaan'])

        l = token_split(r'sql "COLLATE = \"utf8mb4_unicode_ci\";"')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = "utf8mb4_unicode_ci";' ''')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = \"utf8mb4_unicode_ci\";' ''')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = \'utf8mb4_unicode_ci\';' ''')
        self.assertEqual(l, ["sql", "COLLATE = 'utf8mb4_unicode_ci';"])

        l = token_split(r'''sql 'new\nline\rneed \ttab' ''')
        self.assertEqual(l, ["sql", "new\nline\rneed \ttab"])

    def testEscaping(self):
        l = token_split('"Roch\'e" Compaan')
        self.assertEqual(l, ["Roch'e", "Compaan"])
        l = token_split(r'hello\ world')
        self.assertEqual(l, ['hello world'])
        l = token_split(r'\\')
        self.assertEqual(l, ['\\'])
        l = token_split(r'\n')
        self.assertEqual(l, ['\n'])
        l = token_split(r'\r')
        self.assertEqual(l, ['\r'])
        l = token_split(r'\t')
        self.assertEqual(l, ['\t'])

    def testBadQuote(self):
        self.assertRaises(ValueError, token_split, '"hello world')
        self.assertRaises(ValueError, token_split, "Roch'e Compaan")

# vim: set filetype=python ts=4 sw=4 et si

Roundup Issue Tracker: http://roundup-tracker.org/