view website/issues/html/file.item.html @ 6565:2c2dbfc332ba

Try to handle multiple connections better. The session database is a hot spot. When multiple requests (e.g. 20) come in at the same time session database contention can get great. The original code didn't retry session database access when the open failed. This resulted in errors at the client. The second pass delayed 0.01 seconds and retried. It was better but we still had multiple second stalls. I think the first request got in, everybody else backed up and then retried at the same time. Again they stepped on each other. With logging I would see many counters go all the way to low single digits or to -1 indicating falure. This pass uses randomint to generate delays from 0-.125 seconds in 5ms increments. This performs better in testing. I rarely saw a counter less than 13 (2 failed retries). Current logging starts after 6 failures and counts down until success or failure.
author John Rouillard <rouilj@ieee.org>
date Thu, 16 Dec 2021 20:02:00 -0500
parents 53e9694788f5
children
line wrap: on
line source

<tal:block metal:use-macro="templates/page/macros/icing">
<title metal:fill-slot="head_title" i18n:translate="">File display - <span
 i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></title>
<span metal:fill-slot="body_title" tal:omit-tag="python:1"
 i18n:translate="">File display</span>

<td class="content" metal:fill-slot="content">

<p tal:condition="python:not (context.is_view_ok()
 or request.user.hasRole('Anonymous'))" i18n:translate="">
 You are not allowed to view this page.</p>

<p tal:condition="python:not context.is_view_ok()
 and request.user.hasRole('Anonymous')" i18n:translate="">
 Please login with your username and password.</p>

<form method="POST" onSubmit="return submit_once()"
      enctype="multipart/form-data" tal:condition="context/is_view_ok"
      tal:attributes="action context/designator">

<table class="form">
 <tr>
  <th i18n:translate="">Name</th>
  <td tal:content="structure context/name/field"></td>
 </tr>
 <tr>
  <th i18n:translate="">Description</th>
  <td tal:content="structure context/description/field"></td>
 </tr>
 <tr>
  <th i18n:translate="">Content Type</th>
  <td tal:content="structure context/type/field"/>
  <td style="border: none" tal:condition="python: context.is_edit_ok()">Please note that
  for security reasons, it's not permitted to set content type to <i>text/html</i>.</td>
 </tr>
 <tr tal:condition="python:context.is_edit_ok()">
  <td>
   &nbsp;
   <input type="hidden" name="@template" value="item">
   <input type="hidden" name="@required" value="name,type">
   <input type="hidden" name="@multilink"
          tal:condition="python:'@multilink' in request.form"
          tal:attributes="value request/form/@multilink/value">
  </td>
  <td tal:content="structure context/submit">submit button here</td>
 </tr>
</table>
</form>

<!--<p tal:condition="python:utils.sb_is_spam(context)" class="error-message">
   File has been classified as spam.</p>-->

<a tal:condition="python:context.id and context.content.is_view_ok()"
 tal:attributes="href string:file${context/id}/${context/name}"
 i18n:translate="">download</a>

<!--<p tal:condition="python:context.id and not context.content.is_view_ok()">
   Files classified as spam are not available for download by
   unathorized users. If you think the file has been misclassified,
   please login and click on the button for reclassification.
</p>-->


<!--     <form method="POST" onSubmit="return submit_once()"
       enctype="multipart/form-data"
       tal:attributes="action context/designator"
       tal:condition="python:request.user.hasPermission('SB: May Classify')">
 
       <input name="@csrf" type="hidden"
	      tal:attributes="value python:utils.anti_csrf_nonce()">
      <input type="hidden" name="@action" value="spambayes_classify">
      <input type="submit" name="trainspam" value="Mark as SPAM" i18n:attributes="value">
      <input type="submit" name="trainham" value="Mark as HAM (not SPAM)" i18n:attributes="value">
     </form>-->

<tal:block tal:condition="context/id" tal:replace="structure context/history" />

</td>

</tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/