Mercurial > p > roundup > code
view doc/implementation.txt @ 7575:2b0089104f08
flake8: rename loop variable in 'for sendto in sendto:'
Flake8 reported 'B020 Found for loop that reassigns the iterable it is
iterating with each iterable value.'
Renamed loop variable to to_addr. There is a similar construct with a
loop over bcc_sendto with a 'bcc' loop variable. So I assume the loop
varaible can be chnaged w/o issue.
Codecov shows all the affected lines are being tested and the tests I
ran with testmon that should cover that code all passed.
We shall see if a full CI run passes.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 23 Jul 2023 23:40:12 -0400 |
| parents | 81a634b7226e |
| children |
line wrap: on
line source
.. meta:: :description: Additional implementation notes for the Roundup Issue Tracker. Supplement for docstrings in the Roundup package. ==================== Implementation notes ==================== [see also the roundup package docstring] There have been some modifications to the spec. I've marked these in the source with 'XXX' comments when I remember to. In short: Class.find() - may match multiple properties, uses keyword args. Class.filter() - isn't in the spec and it's very useful to have at the Class level. CGI interface index view specifier layout part - lose the '+' from the sorting arguments (it's a reserved URL character ;). Just made no prefix mean ascending and '-' prefix descending. ItemClass - renamed to IssueClass to better match it only having one hypderdb class "issue". Allowing > 1 hyperdb class breaks the "superseder" multilink (since it can only link to one thing, and we'd want bugs to link to support and vice-versa). template - the call="link()" is handled by special-case mechanisms in my top-level CGI handler. In a nutshell, the handler looks for a method on itself called 'index%s' or 'item%s' where %s is a class. Most items pass on to the templating mechanism, but the file class _always_ does downloading. It'll probably stay this way too... template - call="link(property)" may be used to link "the current item" (from an index) - the link text is the property specified. template - added functions that I found very useful: List, History and Submit. template - items must specify the message lists, history, etc. Having them by default was sometimes not wanted. template - index view determines its default columns from the template's ``tal:condition="request/show/<property>"`` directives. template - menu() and field() look awfully similar now .... ;) roundup_admin.py - the command-line tool has a lot more commands at its disposal ----------------- Back to `Table of Contents`_ .. _`Table of Contents`: ../docs.html