view test/test_token.py @ 8177:2967f37e73e4

refactor: issue2551289. invalid REST Accept header stops request Sending a POST, PUT (maybe PATCH) with an accept header that is not application/json or xml (if enabled) used to complete the request before throwing a 406 error. This was wrong. Now it reports an error without dispatching/processing the requested transaction. This is the first of a series of refactors of the dispatch method to make it faster and more readable by using return early pattern and extracting methods from the code. changes: The following now return 406 errors not 400 errors invalid version specified with @apiver in URL. invalid version specified with @apiver in payload body invalid version specified in accept headers as application/vnd.roundup.test-vz+json or version property Parsing the accept header returns a 400 when presented with a parameter without an = sign or other parse error. They used to return a 406 which is wrong since the header is malformed rather than having a value I can't respond to. Some error messages were made clearer. Results in the case of an error are proper json error object rather than text/plain strings. New test added for testdetermine_output_formatBadAccept that test the new method using the same test cases as for testDispatchBadAccept. I intend to extend the test coverage for determine_output_format to cover more cases. This should be a faster unit test than for dispatch. Removed .lower() calls for accept_mime_type as the input values are taken from the values in the __accepted_content_type dict which only has lower case values.
author John Rouillard <rouilj@ieee.org>
date Sun, 08 Dec 2024 01:09:34 -0500
parents 9a74dfeb8620
children
line wrap: on
line source

#
# Copyright (c) 2001 Richard Jones
# This module is free software, and you may redistribute it and/or modify
# under the same terms as Python, so long as this copyright message and
# disclaimer are retained in their original form.
#
# This module is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

import unittest, time

from roundup.token_r import token_split

class TokenTestCase(unittest.TestCase):
    def testValid(self):
        l = token_split('hello world')
        self.assertEqual(l, ['hello', 'world'])

    def testIgnoreExtraSpace(self):
        l = token_split('hello  world ')
        self.assertEqual(l, ['hello', 'world'])

    def testQuoting(self):
        l = token_split('"hello world"')
        self.assertEqual(l, ['hello world'])
        l = token_split("'hello world'")
        self.assertEqual(l, ['hello world'])

    def testEmbedQuote(self):
        l = token_split(r'Roch\'e Compaan')
        self.assertEqual(l, ["Roch'e", "Compaan"])
        l = token_split('address="1 2 3"')
        self.assertEqual(l, ['address=1 2 3'])

    def testEmbedEscapeQuote(self):
        l = token_split(r'"Roch\'e Compaan"')
        self.assertEqual(l, ["Roch'e Compaan"])

        l = token_split(r'"Roch\"e Compaan"')
        self.assertEqual(l, ['Roch"e Compaan'])

        l = token_split(r'sql "COLLATE = \"utf8mb4_unicode_ci\";"')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = "utf8mb4_unicode_ci";' ''')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = \"utf8mb4_unicode_ci\";' ''')
        self.assertEqual(l, ["sql", 'COLLATE = "utf8mb4_unicode_ci";'])

        l = token_split(r'''sql 'COLLATE = \'utf8mb4_unicode_ci\';' ''')
        self.assertEqual(l, ["sql", "COLLATE = 'utf8mb4_unicode_ci';"])

        l = token_split(r'''sql 'new\nline\rneed \ttab' ''')
        self.assertEqual(l, ["sql", "new\nline\rneed \ttab"])

    def testEscaping(self):
        l = token_split('"Roch\'e" Compaan')
        self.assertEqual(l, ["Roch'e", "Compaan"])
        l = token_split(r'hello\ world')
        self.assertEqual(l, ['hello world'])
        l = token_split(r'\\')
        self.assertEqual(l, ['\\'])
        l = token_split(r'\n')
        self.assertEqual(l, ['\n'])
        l = token_split(r'\r')
        self.assertEqual(l, ['\r'])
        l = token_split(r'\t')
        self.assertEqual(l, ['\t'])

    def testBadQuote(self):
        self.assertRaises(ValueError, token_split, '"hello world')
        self.assertRaises(ValueError, token_split, "Roch'e Compaan")

# vim: set filetype=python ts=4 sw=4 et si

Roundup Issue Tracker: http://roundup-tracker.org/