Mercurial > p > roundup > code
view roundup/security.py @ 8472:224ccb8b49ca
refactor: change some classes to use __slots__
Speed up access to and reduce size of some low level classes. A few
classes in security.py, rest.py are heavily used. But for all, it
prevents adding random properties to lower level classes that people
shouldn't be mucking with. While doing this I found some test cases
accessing an invalid property name and this change caused the cases to
crash.
admin.py:
Use new method Role.props_dict() and Permission.props_dict() where
original code just referenced __dict__ when printing Role/Permission.
mlink_expr.py:
Add slots to multiple classes.
Classes Binary and Unary set real properties/attributes. Classes that
inherit from them (Equals, Empty, Not, Or, And) define empty slots
tuple to eliminate need for __dict__.
Class Expression also gets a slot.
rate_limit.py:
RateLimit and Gcra classes get slots.
A couple of pep8 fixes: sort imports, remove trailing spaces on a
line, remove unused noqa comment.
rest.py:
Add slots to class SimulateFieldStorageFromJson and FsValue
classes. The memory savings from this could be useful as well as
speedier access to the attributes.
security.py:
Add slots to Permission class. To prevent conflict between slot
limit_perm_to_props_only and the class variable of the same name,
rename the class variable to limit_perm_to_props_only_default.
Also define method props_dict() to allow other code to get a dict to
iterate over when checking permissions.
Add slots to class Role along with props_dict() method.
Add slots to class Security. Also have to add explicit __dict__ slot
to support test override of the hasPermission() method. Add
props_dict() method, currently unused, but added for symmetry.
support.py:
TruthDict and PrioList gets slots.
test/test_cgi.py:
Fix incorrect setting of permission property. Was setting
permissions. So testing may not have been doing what we thought it
was. Multiple places found with this typo.
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
test/test_xmlrpc.py
Remove setting of permissions in some places where it should
have no effect on the test and looks like it was just copypasta.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 03 Nov 2025 00:13:04 -0500 |
| parents | 43899d99fc4d |
| children | 19152fd94fcf |
line wrap: on
line source
"""Handle the security declarations used in Roundup trackers. """ __docformat__ = 'restructuredtext' import logging import weakref from roundup import hyperdb, support logger = logging.getLogger('roundup.security') class Permission: ''' Defines a Permission with the attributes - name - description - klass (optional) - properties (optional) - check function (optional) - props_only (optional, internal field is limit_perm_to_props_only) default value taken from Permission.limit_perm_to_props_only_default. - filter function (optional) returns filter arguments for determining which records are visible by the user. The filter function comes into play when determining if a set of nodes found via a filter call of a class can be seen by the user -- the normal way would be to call the permissions for each item found, the filter call performs this on the database for all nodes. Signature of the filter function: filter(db, userid, klass) The filter must return a list of dictionaries with filter parameters. Note that sort and group parameters of the filter call should not be set by filter method (they will be overwritten) and the parameter search_matches must not be set. An empty list returned means no access for this filter method. The klass may be unset, indicating that this permission is not locked to a particular class. That means there may be multiple Permissions for the same name for different classes. If property names are set, permission is restricted to those properties only. If check function is set, permission is granted only when the function returns value interpreted as boolean true. The function is called with arguments db, userid, itemid. When the system checks klass permission rather than the klass property permission (i.e. properties=None and item=None), it will apply any permission that matches on permission name and class. If the permission has a check function, the check function will be run. By making the permission valid only for properties using props_only=True the permission will be skipped. You can set the default value for props_only for all properties by calling: db.security.set_props_only_default() with a True or False value. ''' __slots__ = ( "_properties_dict", "check", "check_version", "description", "filter", "klass", "limit_perm_to_props_only", "name", "properties") limit_perm_to_props_only_default = False def __init__(self, name='', description='', klass=None, properties=None, check=None, props_only=None, filter=None): from roundup.anypy import findargspec self.name = name self.description = description self.klass = klass self.properties = properties self._properties_dict = support.TruthDict(properties) self.check = check self.filter = filter if properties is not None: # Set to None unless properties are defined. # This means that: # a=Property(name="Edit", klass="issue", check=dummy, # props_only=True) # b=Property(name="Edit", klass="issue", check=dummy, # props_only=False) # a == b will be true. if props_only is None: self.limit_perm_to_props_only = \ Permission.limit_perm_to_props_only_default else: # see note on use of bool() in set_props_only_default() self.limit_perm_to_props_only = bool(props_only) else: self.limit_perm_to_props_only = None if check is None: self.check_version = 0 if filter is not None: if klass is None: s = "Definition of a filter function" \ " needs a check function if no klass is given" raise ValueError(s) self.check = self.check_factory(klass, filter) self.check_version = 1 else: args = findargspec.findargspec(check) # args[2] is the keywords argument. Leave it as a subscript and # do not use named tuple reference as names change in python 3. # If there is a **parameter defined in the function spec, the # value of the 3rd argument (2nd index) in the tuple is not None. if args[2] is None: # function definition is function(db, userid, itemid) self.check_version = 1 else: # function definition is function(db, userid, itemid, **other) self.check_version = 2 def check_factory(self, klass, filter_function): """ When a Permission defines a filter function but no check function, we manufacture a check function here """ def check(db, userid, itemid): cls = db.getclass(klass) args = filter_function(db, userid, cls) for a in args: if cls.filter([itemid], **a): return True return False return check def props_dict(self): return {name: getattr(self, name) for name in self.__slots__} def test(self, db, permission, classname, property, userid, itemid): ''' Test permissions 5 args: permission - string like Edit, Register etc. Required, no wildcard. classname - string like issue, msg etc. Can be None to match any class. property - array of strings that are property names. Optional. if None this is an item or klass access check. userid - number that is id for user. itemid - id for classname. e.g. 3 in issue3. If missing this is a class access check, otherwies it's a object access check. ''' if permission != self.name: return 0 # are we checking the correct class if self.klass is not None and self.klass != classname: return 0 # what about property? # Note that _properties_dict always returns True if it was # initialized with empty properties if property is not None and not self._properties_dict[property]: return 0 # is this a props_only permission and permissions are set if property is None and self.properties is not None and \ self.limit_perm_to_props_only: return 0 # check code if itemid is not None and self.check is not None: if self.check_version == 1: if not self.check(db, userid, itemid): return 0 elif self.check_version == 2: if not self.check(db, userid, itemid, property=property, permission=permission, classname=classname): return 0 # we have a winner return 1 def searchable(self, classname, property): """ A Permission is searchable for the given permission if it doesn't include a check method and otherwise matches the given parameters. """ if self.name not in ('View', 'Search'): return 0 # are we checking the correct class if self.klass is not None and self.klass != classname: return 0 # Do not allow access if we have a check method if self.check: return 0 # what about property? # Note that _properties_dict always returns True if it was # initialized with empty properties if not self._properties_dict[property]: return 0 return 1 def __repr__(self): return '<Permission 0x%x %r,%r,%r,%r,%r>' % (id(self), self.name, self.klass, self.properties, self.check, self.limit_perm_to_props_only) def __eq__(self, other): if self.name != other.name: return False if self.klass != other.klass: return False if self.properties != other.properties: return False if self.check != other.check: return False if self.limit_perm_to_props_only != \ other.limit_perm_to_props_only: return False # match return True def __ne__(self, other): return not self.__eq__(other) def __getitem__(self, index): return (self.name, self.klass, self.properties, self.check, self.limit_perm_to_props_only)[index] class Role: ''' Defines a Role with the attributes - name - description - permissions ''' __slots__ = ("_permissions", "description", "name") def __init__(self, name='', description='', permissions=None): self.name = name.lower() self.description = description # This is a dict of permission names each containing a dict of # *class names*, with a special entry for non-class permissions # where the key is None. In each class dict we have a dictionary # with the values True and False for permission with and without # a check method. These dicts each contain a list of permissions. if permissions is None: self._permissions = {} elif isinstance(permissions, list): self._permissions = {} for p in permissions: self.addPermission(p) else: raise ValueError("Invalid permissions for Role: %s" % permissions) def __repr__(self): pl = self.permission_list() return '<Role 0x%x %r,%r>' % (id(self), self.name, pl) def addPermission(self, *permissions): for p in permissions: pn = p.name self._permissions.setdefault(pn, {}) cn = p.klass if p.klass not in self._permissions[pn]: self._permissions[pn][cn] = {False: [], True: []} self._permissions[pn][cn][bool(p.check)].append(p) def filter_iter(self, permission, classname): """ Loop over all permissions for the current role on the class with a check method (and props_only False). """ if permission not in self._permissions: return for c in (None, classname): if c not in self._permissions[permission]: continue perms = self._permissions[permission][c][True] for p in perms: if p.limit_perm_to_props_only and p.properties: continue yield p def hasPermission(self, db, perm, uid, classname, property, itemid, chk): # if itemid is given a classname must, too, checked in caller if itemid and classname is None: raise ValueError('classname must accompany itemid') perms = self._permissions if perm not in perms: return False # If we have a classname we also need to check permission with # an empty classname (e.g. 'admin' has access on everything) if classname is not None and None in perms[perm]: for p in perms[perm][None][chk]: # permission match? if p.test(db, perm, classname, property, uid, itemid): return True if classname not in perms[perm]: return False for p in perms[perm][classname][chk]: # permission match? if p.test(db, perm, classname, property, uid, itemid): return True return False def permission_list(self): """ Used for reporting in admin tool """ perm_list = [] for p in self._permissions: for c in self._permissions[p]: for cond in (False, True): perm_list.extend(self._permissions[p][c][cond]) perm_list.sort(key=lambda x: (x.klass or '', x.name)) return perm_list def props_dict(self): return {name: getattr(self, name) for name in self.__slots__} def searchable(self, classname, propname): for perm_name in 'View', 'Search': # Only permissions without a check method if perm_name not in self._permissions: continue perms = self._permissions[perm_name] if classname not in perms and None not in perms: continue if None in perms: for p in perms[None][False]: if p.searchable(classname, propname): return True if classname in perms: for p in perms[classname][False]: if p.searchable(classname, propname): return True return False class Security: # __dict__ is needed to allow mocking of db.security.hasPermission # in test/test_templating.py. Define slots for properties used in # production to increase speed. __slots__ = ("__dict__", "db", "permission", "role") def __init__(self, db): ''' Initialise the permission and role classes, and add in the base roles (for admin user). ''' self.db = weakref.proxy(db) # use a weak ref to avoid circularity # Permissions are mapped by name to a list of Permissions by class self.permission = {} # roles are mapped by name to the Role self.role = {} # the default Roles self.addRole(name="User", description="A regular user, no privs") self.addRole(name="Admin", description="An admin user, full privs") self.addRole(name="Anonymous", description="An anonymous user") # default permissions - Admin may do anything for perm_name in 'create edit restore retire view'.split(): p = self.addPermission(name=perm_name.title(), description="User may %s everything" % perm_name) self.addPermissionToRole('Admin', p) # initialise the permissions and roles needed for the UIs from roundup.cgi import client client.initialiseSecurity(self) from roundup import mailgw mailgw.initialiseSecurity(self) def filter_iter(self, permission, userid, classname): """ Loop over all permissions for the current user on the class with a check method (and props_only False). """ for rolename in self.db.user.get_roles(userid): if not rolename or (rolename not in self.role): continue r = self.role[rolename] for perm in r.filter_iter(permission, classname): yield perm def getPermission(self, permission, classname=None, properties=None, check=None, props_only=None): ''' Find the Permission matching the name and for the class, if the classname is specified. Raise ValueError if there is no exact match. ''' if permission not in self.permission: raise ValueError('No permission "%s" defined' % permission) if classname: try: self.db.getclass(classname) except KeyError: raise ValueError('No class "%s" defined' % classname) # look through all the permissions of the given name tester = Permission(permission, klass=classname, properties=properties, check=check, props_only=props_only) for perm in self.permission[permission]: if perm == tester: return perm raise ValueError('No permission "%s" defined for "%s"' % (permission, classname)) def hasPermission(self, permission, userid, classname=None, property=None, itemid=None, skip_permissions_with_check=False): '''Look through all the Roles, and hence Permissions, and see if "permission" exists given the constraints of classname, property, itemid, and props_only. If classname is specified (and only classname) the search will match: if there is *any* Permission for that classname, and that Permission was not created with props_only = True *NOTE* the Permission will match even if there are additional constraints like a check or properties and props_only is False. This can be unexpected. Using props_only = True or setting the default value to True can help prevent surprises. If property is specified, the Permission matched must have either no properties listed or the property must appear in the list. If itemid is specified, the Permission matched must have either no check function defined or the check function, when invoked, must return a True value. Note that this functionality is actually implemented by the Permission.test() method. ''' if itemid and classname is None: raise ValueError('classname must accompany itemid') # for each of the user's Roles, check the permissions # Note that checks with a check method are typically a lot more # expensive than the ones without. So we check the ones without # a check method first checklist = (False, True) if skip_permissions_with_check: checklist = (False,) for has_check in checklist: for rolename in self.db.user.get_roles(userid): if not rolename or (rolename not in self.role): continue r = self.role[rolename] v = r.hasPermission(self.db, permission, userid, classname, property, itemid, has_check) if v: return v return False def is_filterable(self, permission, userid, classname): """ Check if all permissions for the current user on the class with a check method (and props_only False) also have a filter method. We only consider permissions with props_only set to False. Note that this will return True if there are no permissions with a check method found, the performed checks later will find no matching records. """ for perm in self.filter_iter(permission, userid, classname): if not perm.filter: return False return True def props_dict(self): return {name: getattr(self, name) for name in self.__slots__} def roleHasSearchPermission(self, classname, property, *rolenames): """ For each of the given roles, check the permissions. Property can be a transitive property. """ # Note: break from inner loop means "found" # break from outer loop means "not found" cn = classname prev = None prop = None Link = hyperdb.Link Multilink = hyperdb.Multilink for propname in property.split('.'): if prev: try: cn = prop.classname except AttributeError: break prev = propname try: cls = self.db.getclass(cn) prop = cls.getprops()[propname] except KeyError: break for rn in rolenames: if self.role[rn].searchable(cn, propname): break else: break else: # for Link and Multilink require search permission on label- # and order-properties and on ID if isinstance(prop, (Link, Multilink)): try: cls = self.db.getclass(prop.classname) except KeyError: return 0 props = dict.fromkeys(('id', cls.labelprop(), cls.orderprop())) for p in props: for rn in rolenames: if self.role[rn].searchable(prop.classname, p): break else: return 0 return 1 return 0 def hasSearchPermission(self, userid, classname, property): '''Look through all the Roles, and hence Permissions, and see if "permission" exists given the constraints of classname and property. A search permission is granted if we find a 'View' or 'Search' permission for the user which does *not* include a check function. If such a permission is found, the user may search for the given property in the given class. Note that classname *and* property are mandatory arguments. Contrary to hasPermission, the search will *not* match if there are additional constraints (namely a search function) on a Permission found. Concerning property, the Permission matched must have either no properties listed or the property must appear in the list. ''' roles = [r for r in self.db.user.get_roles(userid) if r and (r in self.role)] return self.roleHasSearchPermission(classname, property, *roles) def addPermission(self, **propspec): ''' Create a new Permission with the properties defined in 'propspec'. See the Permission class for the possible keyword args. ''' perm = Permission(**propspec) self.permission.setdefault(perm.name, []).append(perm) return perm def addRole(self, **propspec): ''' Create a new Role with the properties defined in 'propspec' ''' role = Role(**propspec) self.role[role.name] = role return role def set_props_only_default(self, props_only=None): if props_only is not None: # NOTE: only valid values are True and False because these # will be compared as part of tuple == tuple and # (3,) == (True,) is False even though 3 is a True value # in a boolean context. So use bool() to coerce value. Permission.limit_perm_to_props_only_default = \ bool(props_only) def get_props_only_default(self): return Permission.limit_perm_to_props_only_default def addPermissionToRole(self, rolename, permission, classname=None, properties=None, check=None, props_only=None): ''' Add the permission to the role's permission list. 'rolename' is the name of the role to add the permission to. 'permission' is either a Permission *or* a permission name accompanied by 'classname' (thus in the second case a Permission is obtained by passing 'permission' and 'classname' to self.getPermission) ''' if not isinstance(permission, Permission): permission = self.getPermission(permission, classname, properties, check, props_only) role = self.role[rolename.lower()] role.addPermission(permission) # Convenience methods for removing non-allowed properties from a # filterspec or sort/group list def filterFilterspec(self, userid, classname, filterspec): """ Return a filterspec that has all non-allowed properties removed. """ return {k: v for k, v in filterspec.items() if self.hasSearchPermission(userid, classname, k)} def filterSortspec(self, userid, classname, sort): """ Return a sort- or group-list that has all non-allowed properties removed. """ if isinstance(sort, tuple) and sort[0] in '+-': sort = [sort] return [(d, p) for d, p in sort if self.hasSearchPermission(userid, classname, p)] # vim: set filetype=python sts=4 sw=4 et si :
