Mercurial > p > roundup > code
view roundup/cgi/exceptions.py @ 5775:17e110426ad7
issue2551046: Attempts to attach file or create large message fail
under python2
This patch fixes a bug introduced for working around an issue in
python3. There were a few ways to fix this, but I think this fix:
1) follows the spirit of the original patch
2) follows python programming expectations
I am still having an issue trying to get both code paths executed from
the test suite. The super code path is not tested, but I did validate
that path from the browser and it works producing valid uploaded files
in both python 2 and 3.
Thanks to Ezio Melotti and Joseph Myers for their help in guiding me
to come up with this solution.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 08 Jun 2019 21:10:39 -0400 |
| parents | 07abc8d36940 |
| children | 1a835db41674 |
line wrap: on
line source
"""Exceptions for use in Roundup's web interface. """ __docformat__ = 'restructuredtext' from roundup.exceptions import LoginError, Unauthorised import cgi class HTTPException(BaseException): pass class Redirect(HTTPException): pass class NotFound(HTTPException): pass class NotModified(HTTPException): pass class PreconditionFailed(HTTPException): pass class DetectorError(BaseException): """Raised when a detector throws an exception. Contains details of the exception.""" def __init__(self, subject, html, txt): self.subject = subject self.html = html self.txt = txt class FormError(ValueError): """An 'expected' exception occurred during form parsing. That is, something we know can go wrong, and don't want to alarm the user with. We trap this at the user interface level and feed back a nice error to the user. """ pass class SendFile(BaseException): """Send a file from the database.""" class SendStaticFile(BaseException): """Send a static file from the instance html directory.""" class SeriousError(BaseException): """Raised when we can't reasonably display an error message on a templated page. The exception value will be displayed in the error page, HTML escaped. """ def __str__(self): return """ <html><head><title>Roundup issue tracker: An error has occurred</title> <link rel="stylesheet" type="text/css" href="@@file/style.css"> </head> <body class="body" marginwidth="0" marginheight="0"> <p class="error-message">%s</p> </body></html> """%cgi.escape(self.args[0]) # vim: set filetype=python sts=4 sw=4 et si :
