Mercurial > p > roundup > code
view test/test_sqlite.py @ 5161:12190efa30d4
I realized that the __came_from and __redirect_to url parameters I
added to handle issues with the LoginAction and NewItemAction could
be used for XSS or other purposes.
So I check them using a new clean_url(url) function. This tries to
validate that the url is under the tracker's base url and that the
components of the url are properly url encoded. If it thinks something
is wrong with the url, it will raise a ValueError. I decided to not
attempt to fix the url's if there is an issue, better to bring it to the
tracker admin's attention.
Changed the code paths in NewItemAction and LoginAction that deal with
the form parameters to use the clean_url function on the form input
first.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 23 Jul 2016 14:00:49 -0400 |
| parents | 364c54991861 |
| children | efb34cbdba7c |
line wrap: on
line source
# # Copyright (c) 2001 Bizar Software Pty Ltd (http://www.bizarsoftware.com.au/) # This module is free software, and you may redistribute it and/or modify # under the same terms as Python, so long as this copyright message and # disclaimer are retained in their original form. # # IN NO EVENT SHALL BIZAR SOFTWARE PTY LTD BE LIABLE TO ANY PARTY FOR # DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES ARISING # OUT OF THE USE OF THIS CODE, EVEN IF THE AUTHOR HAS BEEN ADVISED OF THE # POSSIBILITY OF SUCH DAMAGE. # # BIZAR SOFTWARE PTY LTD SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, # BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS # FOR A PARTICULAR PURPOSE. THE CODE PROVIDED HEREUNDER IS ON AN "AS IS" # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. import unittest, os, shutil, time from roundup.backends import get_backend, have_backend from db_test_base import DBTest, ROTest, SchemaTest, ClassicInitTest, config from db_test_base import ConcurrentDBTest, FilterCacheTest class sqliteOpener: if have_backend('sqlite'): module = get_backend('sqlite') def nuke_database(self): shutil.rmtree(config.DATABASE) class sqliteDBTest(sqliteOpener, DBTest, unittest.TestCase): pass class sqliteROTest(sqliteOpener, ROTest, unittest.TestCase): pass class sqliteSchemaTest(sqliteOpener, SchemaTest, unittest.TestCase): pass class sqliteClassicInitTest(ClassicInitTest, unittest.TestCase): backend = 'sqlite' class sqliteConcurrencyTest(ConcurrentDBTest, unittest.TestCase): backend = 'sqlite' class sqliteFilterCacheTest(sqliteOpener, FilterCacheTest, unittest.TestCase): backend = 'sqlite' from session_common import RDBMSTest class sqliteSessionTest(sqliteOpener, RDBMSTest, unittest.TestCase): pass
