Mercurial > p > roundup > code
view doc/index.txt @ 5161:12190efa30d4
I realized that the __came_from and __redirect_to url parameters I
added to handle issues with the LoginAction and NewItemAction could
be used for XSS or other purposes.
So I check them using a new clean_url(url) function. This tries to
validate that the url is under the tracker's base url and that the
components of the url are properly url encoded. If it thinks something
is wrong with the url, it will raise a ValueError. I decided to not
attempt to fix the url's if there is an issue, better to bring it to the
tracker admin's attention.
Changed the code paths in NewItemAction and LoginAction that deal with
the form parameters to use the clean_url function on the form input
first.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 23 Jul 2016 14:00:49 -0400 |
| parents | 487dc55e3c5e |
| children | 3e1b66c4e1e2 |
line wrap: on
line source
======================================================= Roundup: an Issue-Tracking System for Knowledge Workers ======================================================= For how to contact the community see http://www.roundup-tracker.org . Contents ======== .. toctree:: :maxdepth: 2 features installation upgrading FAQ user_guide customizing admin_guide debugging xmlrpc overview Design (original) <design> developers tracker_templates Notes about the MySQL Database backend <mysql> Notes about the PostgreSQL Database backend <postgresql> glossary acknowledgements Richard Jones implementation notes <implementation> license