Mercurial > p > roundup > code
diff roundup/backends/rdbms_common.py @ 4059:ef0b4396888a
Enhance and simplify logging.
| author | Stefan Seefeld <stefan@seefeld.name> |
|---|---|
| date | Fri, 20 Feb 2009 04:38:34 +0000 |
| parents | 27a9906cd8d1 |
| children | 2a68d7494bbc |
line wrap: on
line diff
--- a/roundup/backends/rdbms_common.py Fri Feb 20 04:07:04 2009 +0000 +++ b/roundup/backends/rdbms_common.py Fri Feb 20 04:38:34 2009 +0000 @@ -15,7 +15,6 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -#$Id: rdbms_common.py,v 1.199 2008-08-18 06:25:47 richard Exp $ """ Relational database (SQL) backend common code. Basics: @@ -157,8 +156,7 @@ def sql(self, sql, args=None): """ Execute the sql with the optional args. """ - if __debug__: - logging.getLogger('hyperdb').debug('SQL %r %r'%(sql, args)) + self.log_debug('SQL %r %r'%(sql, args)) if args: self.cursor.execute(sql, args) else: @@ -262,8 +260,7 @@ return 0 if version < 2: - if __debug__: - logging.getLogger('hyperdb').info('upgrade to version 2') + log_info('upgrade to version 2') # change the schema structure self.database_schema = {'tables': self.database_schema} @@ -276,8 +273,7 @@ self.create_version_2_tables() if version < 3: - if __debug__: - logging.getLogger('hyperdb').info('upgrade to version 3') + log_info('upgrade to version 3') self.fix_version_2_tables() if version < 4: @@ -775,9 +771,8 @@ def addnode(self, classname, nodeid, node): """ Add the specified node to its class's db. """ - if __debug__: - logging.getLogger('hyperdb').debug('addnode %s%s %r'%(classname, - nodeid, node)) + self.log_debug('addnode %s%s %r'%(classname, + nodeid, node)) # determine the column definitions and multilink tables cl = self.classes[classname] @@ -850,9 +845,8 @@ def setnode(self, classname, nodeid, values, multilink_changes={}): """ Change the specified node. """ - if __debug__: - logging.getLogger('hyperdb').debug('setnode %s%s %r' - % (classname, nodeid, values)) + self.log_debug('setnode %s%s %r' + % (classname, nodeid, values)) # clear this node out of the cache if it's in there key = (classname, nodeid) @@ -1113,9 +1107,8 @@ # create the journal entry cols = 'nodeid,date,tag,action,params' - if __debug__: - logging.getLogger('hyperdb').debug('addjournal %s%s %r %s %s %r'%(classname, - nodeid, journaldate, journaltag, action, params)) + self.log_debug('addjournal %s%s %r %s %s %r'%(classname, + nodeid, journaldate, journaltag, action, params)) # make the journalled data marshallable if isinstance(params, type({})): @@ -1140,10 +1133,9 @@ dc = self.hyperdb_to_sql_value[hyperdb.Date] for nodeid, journaldate, journaltag, action, params in journal: - if __debug__: - logging.getLogger('hyperdb').debug('addjournal %s%s %r %s %s %r'%( - classname, nodeid, journaldate, journaltag, action, - params)) + self.log_debug('addjournal %s%s %r %s %s %r'%( + classname, nodeid, journaldate, journaltag, action, + params)) # make the journalled data marshallable if isinstance(params, type({})): @@ -2114,7 +2106,7 @@ backward-compatibility reasons a single (dir, prop) tuple is also allowed. - "search_matches" is a sequence type or None + "search_matches" is a container type or None The filter must match all properties specificed. If the property value to match is a list:
