Mercurial > p > roundup > code
diff test/rest_common.py @ 5650:e8ca7072c629
Fix Python 3 issues in REST code.
* Need to use .get not .getheader for HTTP headers (see hg commit
fec18298ae02, "Python 3 preparation: HTTP headers handling in
roundup_server.py.").
* Need to use key not cmp with sort (see hg commit 3fa026621f69,
"Python 3 preparation: comparisons.").
* dispatch output must be bytes, not str, otherwise writing it to the
socket (e.g. in roundup-server) will fail.
This fixes issues shown up attempting to access the REST interface
with a browser with Python 3 (as opposed to with the Roundup
testsuite, which also has known REST issues with Python 3).
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Sun, 17 Mar 2019 16:25:36 +0000 |
| parents | 095db27e8064 |
| children | a02ef29b4242 |
line wrap: on
line diff
--- a/test/rest_common.py Fri Mar 15 20:29:00 2019 -0400 +++ b/test/rest_common.py Sun Mar 17 16:25:36 2019 +0000 @@ -68,7 +68,7 @@ 'TRACKER_NAME': 'rounduptest' } self.dummy_client = client.Client(self.instance, MockNull(), env, [], None) - self.dummy_client.request.headers.getheader = self.get_header + self.dummy_client.request.headers.get = self.get_header self.empty_form = cgi.FieldStorage() self.server = RestfulInstance(self.dummy_client, self.db) @@ -426,7 +426,7 @@ form = cgi.FieldStorage(body_file, headers=headers, environ=env) - self.server.client.request.headers.getheader=self.get_header + self.server.client.request.headers.get=self.get_header results = self.server.dispatch('PUT', "/rest/data/user/%s/realname"%self.joeid, form) @@ -455,7 +455,7 @@ form = cgi.FieldStorage(body_file, headers=headers, environ=env) - self.server.client.request.headers.getheader=self.get_header + self.server.client.request.headers.get=self.get_header results = self.server.dispatch('PUT', "/rest/data/user/%s/realname"%self.joeid, form) @@ -483,7 +483,7 @@ cgi.MiniFieldStorage('data', 'Joe Doe'), ] self.headers = headers - self.server.client.request.headers.getheader = self.get_header + self.server.client.request.headers.get = self.get_header results = self.server.dispatch('PUT', "/rest/data/user/%s/realname"%self.joeid, form) @@ -523,7 +523,7 @@ form = cgi.FieldStorage(body_file, headers=headers, environ=env) - self.server.client.request.headers.getheader=self.get_header + self.server.client.request.headers.get=self.get_header results = self.server.dispatch('PATCH', "/rest/data/user/%s"%self.joeid, form) @@ -544,7 +544,7 @@ form = cgi.FieldStorage(body_file, headers=headers, environ=env) - self.server.client.request.headers.getheader=self.get_header + self.server.client.request.headers.get=self.get_header results = self.server.dispatch('PATCH', "/rest/data/user/%s"%self.joeid, form) @@ -571,7 +571,7 @@ form = cgi.FieldStorage(body_file, headers=headers, environ=env) - self.server.client.request.headers.getheader=self.get_header + self.server.client.request.headers.get=self.get_header results = self.server.dispatch('POST', "/rest/data/issue", form)