Mercurial > p > roundup > code
diff CHANGES.txt @ 7690:d17e57220a62 2.3.1a0
fix: close file properly in indexer_dbm.py:save_index()
Fix this error found in debug logs of gentoo packaging of round 2.2.0.
/roundup/backends/indexer_dbm.py:253: ResourceWarning: unclosed file
<_io.BufferedWriter name='test-index/indexes/index.db-'>
open(self.indexdb+'-', 'wb').write(zlib.compress(marshal.dumps(dbfil)))
Also added test that calls save_index(), reloads the index and tests
that the original item. I am not sure how Gentoo hit
this But they were missing a number of backends. So it's possible that
indexer_dbm.py is not getting fully tested depending on what is
installed on the system. Codecov from CI didnt show
indexer_dbm.py:save_index() being covered.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 02 Nov 2023 18:55:47 -0400 |
| parents | a27f30709d46 |
| children | 78585199552a 54eb12cd3be1 |
line wrap: on
line diff
--- a/CHANGES.txt Mon Oct 30 21:57:21 2023 -0400 +++ b/CHANGES.txt Thu Nov 02 18:55:47 2023 -0400 @@ -73,6 +73,7 @@ Rouillard) - fix repeated password id with user.item.html in all templates except jinja2. (John Rouillard) +- fix unclosed file when saving index in indexer_dbm.py. (John Rouillard) Features: