Mercurial > p > roundup > code
diff roundup/backends/rdbms_common.py @ 6431:ada1edcc9132
issue2551142 - Import ... unique constraint failure.
Full title: Import of retired node with username after active node
fails with unique constraint failure.
Fix this in two ways:
1) sort export on keyname, retired status so that retired nodes for a
given keyname are before the acive node in the export file.
This stops generating a broken export.
2) handle importing a broken export by deactivating/fixing up/clearing
the active record's unique index entry temporarily. Redo the
import of the retired node and resetting the active record to active.
The fixup changes the unique index (keyvalue, __retired__) from
(keyvalue, 0) to (keyvalue, -1). Then it retries the failed import of
a retired record with keyvalue. I use -1 in case something goes wrong,
It makes the record stand out in the database allowing hand recovery
if needed. Rather than using -1 I could just use the id of the record
like a normal retirement does.
If the retry of the import fails (raises exception), reset the active
record from -1 back to 0 and raise the exception.
If it succeeds, reset the active record from -1 back to 0 and continue
the import process.
Reset __retired__ from -1 to 0 on every import. I don't think the
performance loss from resetting on every exception matters as there
should be very few exceptions. Also this makes the code more
understandable. There is no reason to leave the -1 value in place and
do a bulk rest of -1 to 0 after the class csv file is loaded.
Also if a fixup is needed it is logged at level info with the rest of
the database logging. Also success of the fixup is logged. Fixup
failure generates a propagated exception.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 07 Jun 2021 09:58:39 -0400 |
| parents | dbacf6bf2a2f |
| children | c1d3fbcdbfbd |
line wrap: on
line diff
--- a/roundup/backends/rdbms_common.py Sat Jun 05 23:43:42 2021 -0400 +++ b/roundup/backends/rdbms_common.py Mon Jun 07 09:58:39 2021 -0400 @@ -3113,6 +3113,9 @@ Return the nodeid of the node imported. """ + + logger = logging.getLogger('roundup.hyperdb.backend') + if self.db.journaltag is None: raise DatabaseError(_('Database open read-only')) properties = self.getprops() @@ -3168,19 +3171,57 @@ if newid is None: newid = self.db.newid(self.classname) + activeid = None + has_node = False + + # use the arg for __retired__ to cope with any odd database type + # conversion (hello, sqlite) + retired_sql = 'update _%s set __retired__=%s where id=%s'%( + self.classname, self.db.arg, self.db.arg) + # insert new node or update existing? - if not self.hasnode(newid): - self.db.addnode(self.classname, newid, d) # insert - else: - self.db.setnode(self.classname, newid, d) # update + # if integrity error raised try to recover + try: + has_node = self.hasnode(newid) + if not has_node: + self.db.addnode(self.classname, newid, d) # insert + else: + self.db.setnode(self.classname, newid, d) # update + # Blech, different db's return different exceptions + # so I can't list them here as some might not be defined + # on a given system. So capture all exceptions from the + # code above and try to correct it. If it's correctable its + # some form of Uniqueness Failure/Integrity Error otherwise + # undo the fixup and pass on the error. + except Exception as e: + logger.info('Attempting to handle import exception ' + 'for id %s: %s' % (newid,e)) + + keyname = self.db.user.getkey() + if has_node or not keyname: # Not an integrity error + raise + activeid = self.db.user.lookup(d[keyname]) + self.db.sql(retired_sql, (-1, activeid)) # clear the active node + # this can only happen on an addnode, so retry + try: + # if this raises an error, let it propagate upward + self.db.addnode(self.classname, newid, d) # insert + except Exception: + # undo the database change + self.db.sql(retired_sql, (0, activeid)) # clear the active node + raise # propagate + logger.info('Successfully handled import exception ' + 'for id %s which conflicted with %s' % ( + newid, activeid)) # retire? if retire: - # use the arg for __retired__ to cope with any odd database type - # conversion (hello, sqlite) - sql = 'update _%s set __retired__=%s where id=%s'%(self.classname, - self.db.arg, self.db.arg) - self.db.sql(sql, (newid, newid)) + self.db.sql(retired_sql, (newid, newid)) + + if activeid: + # unretire the active node + self.db.sql(retired_sql, ('0', activeid)) + return newid def export_journals(self):