Mercurial > p > roundup > code
diff roundup/mailgw.py @ 431:a28a80b714f9
Eliminate database close method by using weakrefs.
. We now use weakrefs in the Classes to keep the database reference, so
the close() method on the database is no longer needed.
I bumped the minimum python requirement up to 2.1 accordingly.
. [SF#487480] roundup-server
. [SF#487476] INSTALL.txt
I also cleaned up the change message / post-edit stuff in the cgi client.
There's now a clearly marked "TODO: append the change note" where I believe
the change note should be added there. The "changes" list will obviously
have to be modified to be a dict of the changes, or somesuch.
More testing needed.
| author | Richard Jones <richard@users.sourceforge.net> |
|---|---|
| date | Sun, 02 Dec 2001 05:06:16 +0000 |
| parents | 350685601f37 |
| children | 2441743e335b |
line wrap: on
line diff
--- a/roundup/mailgw.py Sat Dec 01 07:17:50 2001 +0000 +++ b/roundup/mailgw.py Sun Dec 02 05:06:16 2001 +0000 @@ -73,7 +73,7 @@ an exception, the original message is bounced back to the sender with the explanatory message given in the exception. -$Id: mailgw.py,v 1.38 2001-12-01 07:17:50 richard Exp $ +$Id: mailgw.py,v 1.39 2001-12-02 05:06:16 richard Exp $ ''' @@ -352,11 +352,8 @@ author = self.db.uidFromAddress(message.getaddrlist('from')[0]) # reopen the database as the author username = self.db.user.get(author, 'username') - self.db.close() self.db = self.instance.open(username) - self.handle_message(author, username, - # re-get the class with the new database connection cl = self.db.getclass(classname) @@ -601,6 +598,15 @@ # # $Log: not supported by cvs2svn $ +# Revision 1.38 2001/12/01 07:17:50 richard +# . We now have basic transaction support! Information is only written to +# the database when the commit() method is called. Only the anydbm +# backend is modified in this way - neither of the bsddb backends have been. +# The mail, admin and cgi interfaces all use commit (except the admin tool +# doesn't have a commit command, so interactive users can't commit...) +# . Fixed login/registration forwarding the user to the right page (or not, +# on a failure) +# # Revision 1.37 2001/11/28 21:55:35 richard # . login_action and newuser_action return values were being ignored # . Woohoo! Found that bloody re-login bug that was killing the mail
