Mercurial > p > roundup > code
diff CHANGES.txt @ 5684:97e2125e064c
When we generate links from URL's in messages, we add rel="nofollow"
to combat link spam. This change turns that into rel="nofollow
noopener". This prevents the page at the end of the link from having
access to the roundup window that displays the link.
Details on the issue are are at:
https://mathiasbynens.github.io/rel-noopener/
search web for noopener vulnerability. This problem usually requires a
target="_blank" to really exploit it and we don't provide that. But
adding noopener is extra protection.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 30 Mar 2019 21:15:33 -0400 |
| parents | e70885fe72a4 |
| children | aa13a517cc63 |
line wrap: on
line diff
--- a/CHANGES.txt Sat Mar 30 16:19:00 2019 -0400 +++ b/CHANGES.txt Sat Mar 30 21:15:33 2019 -0400 @@ -112,6 +112,9 @@ - issue2551026: template variable not defined even though it is. Fix issue where variables defined in TAL expression are not available in the scope of the definition. (Tom Ekberg (tekberg)) +- Make all links created with rel=nofollow include noopener. Deals + with possible hijack of original page due to malicious link target. + https://mathiasbynens.github.io/rel-noopener/ (John Rouillard) 2018-07-13 1.6.0