Mercurial > p > roundup > code
diff CHANGES.txt @ 7155:89a59e46b3af
improve REST interface security
When using REST, we reflect the client's origin. If the wildcard '*'
is used in allowed_api_origins all origins are allowed. When this is
done, it also added an 'Access-Control-Allow-Credentials: true'
header.
This Credentials header should not be added if the site is matched
only by '*'. This header should be provided only for explicit origins
(e.g. https://example.org) not for the wildcard.
This is now fixed for CORS preflight OPTIONS request as well as normal
GET, PUT, DELETE, POST, PATCH and OPTIONS requests.
A missing Access-Control-Allow-Credentials will prevent the tracker
from being accessed using credentials. This prevents an unauthorized
third party web site from using a user's credentials to access
information in the tracker that is not publicly available.
Added test for this specific case.
In addition, allowed_api_origins can include explicit origins in
addition to '*'. '*' must be first in the list.
Also adapted numerous tests to work with these changes.
Doc updates.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 23 Feb 2023 12:01:33 -0500 |
| parents | c087ad45bf4d |
| children | 6f09103a6522 |
line wrap: on
line diff
--- a/CHANGES.txt Tue Feb 21 23:06:15 2023 -0500 +++ b/CHANGES.txt Thu Feb 23 12:01:33 2023 -0500 @@ -65,6 +65,9 @@ Schlatterbeck) - Update some template schema files to assign Register permissions for the Anonymous user. Replaces the old Create permission. (John Rouillard) +- Allow '*' and explicit origins in allowed_api_origins. Only return + 'Access-Control-Allow-Credentials' when not matching '*'. Fixes + security issue with rest when using '*'. Features:
