Mercurial > p > roundup > code
diff test/test_liveserver.py @ 8241:741ea8a86012
fix: issue2551374. Error handling for filter expressions.
Errors in filter expressions are now reported. The UI needs some work
but even the current code is helpful when debugging filter
expressions.
mlink_expr:
defines/raises ExpressionError(error string template,
context=dict())
raises ExpressionError when it detects errors when popping arguments
off stack
raises ExpressionError when more than one element left on the stack
before returning
also ruff fix to group boolean expression with parens
back_anydbm.py, rdbms_common.py:
catches ExpressionError, augments context with class and
attribute being searched. raises the exception
for both link and multilink relations
client.py
catches ExpressionError returning a basic error page. The page is a
dead end. There are no links or anything for the user to move
forward. The user has to go back, possibly refresh the page (because
the submit button may be disalbled) re-enter the query and try
again.
This needs to be improved.
test_liveserver.py
test the error page generated by client.py
db_test_base
unit tests for filter with too few arguments, too many arguments,
check all repr and str formats.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 30 Dec 2024 20:22:55 -0500 |
| parents | 9404d56d830f |
| children | 393dfc750d8b |
line wrap: on
line diff
--- a/test/test_liveserver.py Mon Dec 30 02:59:27 2024 -0500 +++ b/test/test_liveserver.py Mon Dec 30 20:22:55 2024 -0500 @@ -351,6 +351,41 @@ # of the footer is missing. self.assertNotIn('out of', f.text) + def test_broken_query(self): + # query link item + current_user_query = ( + "@columns=title,id,activity,status,assignedto&" + "@sort=activity&@group=priority&@filter=creator&" + "@pagesize=50&@startwith=0&creator=-2&" + "@dispname=Test1") + + session, _response = self.create_login_session() + f = session.get(self.url_base()+'/issue?' + current_user_query) + + # verify the query has run by looking for the query name + # print(f.text) + self.assertIn('Error when searching issue by creator using: ' + '[-2]. The operator -2 (not) at position 1 has ' + 'too few arguments.', + f.text) + + def test_broken_multiink_query(self): + # query multilink item + current_user_query = ( + "@columns=title,id,activity,status,assignedto" + "&keyword=-3&@sort=activity&@group=priority" + "&@pagesize=50&@startwith=0&@template=index|search" + "&@action=search") + session, _response = self.create_login_session() + f = session.get(self.url_base()+'/issue?' + current_user_query) + + # verify the query has run by looking for the query name + print(f.text) + self.assertIn('Error when searching issue by keyword using: ' + '[-3]. The operator -3 (and) at position 1 has ' + 'too few arguments.', + f.text) + def test_start_page(self): """ simple test that verifies that the server can serve a start page. """