diff roundup/cgi/actions.py @ 5350:66a17c80e035

Force all uses of random to use SystemRandom and abort if pseudorandom random.Random would be used rather than Random.SystemRandom. random.Random is returning the same value time after time. Even when being seeded after instantiation, calls to the random.random() function return the same value like it's not advanceing the state of the generator. So "fix" is to force use of system random generator to generate: one time keys for password reset (action.py) random passwords when resetting passwords (password.py) serial number for auto ssl cert generation (roundup_server.py) Message-ID's in email: mailgw.py, client.py anti-csrf nonces (templating.py)
author John Rouillard <rouilj@ieee.org>
date Sat, 07 Jul 2018 22:02:41 -0400
parents ed6153d3ee6a
children 91954be46a66
line wrap: on
line diff
--- a/roundup/cgi/actions.py	Thu Jul 05 22:48:50 2018 -0400
+++ b/roundup/cgi/actions.py	Sat Jul 07 22:02:41 2018 -0400
@@ -1,6 +1,15 @@
-import re, cgi, time, random, csv, codecs
+import re, cgi, time, csv, codecs
 from io import BytesIO
 
+try: 
+    # Use the cryptographic source of randomness if available
+    from random import SystemRandom
+    random=SystemRandom()
+except ImportError:
+    raise
+    from random import Random
+    random=Random()
+
 from roundup import hyperdb, token, date, password
 from roundup.actions import Action as BaseAction
 from roundup.i18n import _

Roundup Issue Tracker: http://roundup-tracker.org/