Mercurial > p > roundup > code
diff CHANGES.txt @ 6834:5129fc03dc1f
issue2551137, 2551138 - roundup-server SSL issues.
Python3 no longer supports socket._fileobject, so fake it using
SocketIO and layering io.BufferedReader as in:
https://bugs.launchpad.net/python-glanceclient/+bug/1812525
Also handle SSL.ZeroReturnError exception by ignoring it. This
exception is thrown when the SSL layer has been closed and a read
happens. There is a warning in openssl as well as python docs that the
underlying (unencrypted) socket may not be closed. In manual testing,
netstat -anp didn't show any unclosed socket so.... Could it leak a fd
still, unknown.
This also seesm to have fixed an error when running under python2
where socket shutdown throws an error. Maybe ignoring ZeroErrorREturn
handled that case?
Also added doc to man page recommending not using -s and using a real
web server instead. Also added doc on format of pem file passed to -e.
No automated testing on this, so no test updates 8-(.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 18 Aug 2022 14:44:16 -0400 |
| parents | 234fefd7568a |
| children | 393430d4849a |
line wrap: on
line diff
--- a/CHANGES.txt Tue Aug 16 22:42:38 2022 -0400 +++ b/CHANGES.txt Thu Aug 18 14:44:16 2022 -0400 @@ -30,6 +30,12 @@ - added more testing of BasicDatabase to support use of SQLite for that purpose. Had to fix memory, rdbms and dbm edge cases due to new tests. (John Rouillard) +- issue2551138 - roundup-server with ssl under python2 throws + traceback on socket close. Not sure how this got fixed, + but after fixing issue2551137 it was not an issue anymore. +- issue2551137 - roundup-server won't run with ssl under python3 + Fixed by using SocketIO and manually adding buffering io and + catching SSL.ZeroReturnError indicating SSL has been shut down. Features:
