Mercurial > p > roundup > code
diff roundup/test/memorydb.py @ 7211:506c86823abb
Add config argument to more password.Password invocations.
The work done to allow password_pbkdf2_default_rounds to be overridden
for testing requires that calls to password.Password include a config
argument.
This was needed because using the real value more than quadrupled
testing runtime.
However there are still a few places where config was not being set
when Password was called. I think this fixes all of the ones that are
called from a function that have access to a db.config object.
The remaining ones all call Password(encrypted=x). This results in
Password.unpack() being called. If x is not a propertly formatted
password string ("{scheme}...", it calls encodePassword. It then
should end up raising the ConfigNotSet exception. This is
probably what we want as it means the shape of "x" is not correct.
I don't understand why Password.unpack() attempts to encrypt the value
of encrypted if it doesn't match the right form. According to codecov,
this encryption branch is being used, so somewhere x is of the wrong
form. Hmmm....
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 04 Mar 2023 00:17:26 -0500 |
| parents | b1130680d4ed |
| children | 617d85ce4ac3 |
line wrap: on
line diff
--- a/roundup/test/memorydb.py Fri Mar 03 18:18:26 2023 -0500 +++ b/roundup/test/memorydb.py Sat Mar 04 00:17:26 2023 -0500 @@ -62,7 +62,7 @@ initial_data = os.path.join(prefix, 'initial_data.py') vars = dict(db=db, admin_email='admin@test.com', - adminpw=password.Password('sekrit')) + adminpw=password.Password('sekrit', config=db.config)) fd = open(initial_data) exec(compile(fd.read(), initial_data, 'exec'), vars) fd.close() @@ -110,7 +110,8 @@ ''' if create: db.user.create(username="fred", roles='User', - password=password.Password('sekrit'), + password=password.Password('sekrit', + config=db.config), address='fred@example.com') db.security.addPermissionToRole('User', 'Email Access')
