diff roundup/backends/back_mysql.py @ 7211:506c86823abb

Add config argument to more password.Password invocations. The work done to allow password_pbkdf2_default_rounds to be overridden for testing requires that calls to password.Password include a config argument. This was needed because using the real value more than quadrupled testing runtime. However there are still a few places where config was not being set when Password was called. I think this fixes all of the ones that are called from a function that have access to a db.config object. The remaining ones all call Password(encrypted=x). This results in Password.unpack() being called. If x is not a propertly formatted password string ("{scheme}...", it calls encodePassword. It then should end up raising the ConfigNotSet exception. This is probably what we want as it means the shape of "x" is not correct. I don't understand why Password.unpack() attempts to encrypt the value of encrypted if it doesn't match the right form. According to codecov, this encryption branch is being used, so somewhere x is of the wrong form. Hmmm....
author John Rouillard <rouilj@ieee.org>
date Sat, 04 Mar 2023 00:17:26 -0500
parents 83fa81f084bc
children 8b31893f5930
line wrap: on
line diff
--- a/roundup/backends/back_mysql.py	Fri Mar 03 18:18:26 2023 -0500
+++ b/roundup/backends/back_mysql.py	Sat Mar 04 00:17:26 2023 -0500
@@ -328,7 +328,7 @@
                     elif isinstance(prop, hyperdb.Interval) and v is not None:
                         v = date.Interval(v)
                     elif isinstance(prop, hyperdb.Password) and v is not None:
-                        v = password.Password(encrypted=v)
+                        v = password.Password(encrypted=v, config=self.config)
                     elif isinstance(prop, hyperdb.Integer) and v is not None:
                         v = int(v)
                     elif (isinstance(prop, hyperdb.Boolean) or

Roundup Issue Tracker: http://roundup-tracker.org/