diff roundup/cgi/actions.py @ 5503:4f6e1ce89557

always encode query parameters in sorted order
author Christof Meerwald <cmeerw@cmeerw.org>
date Thu, 16 Aug 2018 20:14:09 +0100
parents 52cb53eedf77
children cd0ceb2afdb8
line wrap: on
line diff
--- a/roundup/cgi/actions.py	Thu Aug 16 19:23:14 2018 +0100
+++ b/roundup/cgi/actions.py	Thu Aug 16 20:14:09 2018 +0100
@@ -1221,7 +1221,7 @@
                                                 redirect_url_tuple.netloc,
                                                 redirect_url_tuple.path,
                                                 redirect_url_tuple.params,
-                                                urllib_.urlencode(query, doseq=True),
+                                                urllib_.urlencode(list(sorted(query.items())), doseq=True),
                                                 redirect_url_tuple.fragment)
                                            )
 
@@ -1239,7 +1239,7 @@
                                                     redirect_url_tuple.netloc,
                                                     redirect_url_tuple.path,
                                                     redirect_url_tuple.params,
-                                                    urllib_.urlencode(query, doseq=True),
+                                                    urllib_.urlencode(list(sorted(query.items())), doseq=True),
                                                     redirect_url_tuple.fragment )
                                                )
                 raise exceptions.Redirect(redirect_url)

Roundup Issue Tracker: http://roundup-tracker.org/