Python 3 preparation: comparisons. Python 3 no longer has the cmp function, or cmp= arguments to sorting functions / methods (key= must be used instead), and requires rich comparison methods such as __lt__ to be defined instead of using __cmp__. All of the comparison mechanisms supported in Python 3 are also supported in Python 2. This patch makes the corresponding changes in Roundup to use key functions and rich comparison methods. In the case of the JournalPassword and Permission classes, only __eq__ and __ne__ are defined as I don't see ordered comparisons as useful there (and for Permission, the old __cmp__ function didn't try to provide a valid ordering). In the case of the Date class, I kept the __cmp__ method and implemented the others in terms of it, to avoid excess repetitiveness in duplicating implementation code for all six rich comparison methods. In roundup/admin.py, help_commands_html used operator.attrgetter to produce the second argument of sorted() - which would be reasonable for a key function, but the second argument is the cmp function in Python 2, not a key function (and the key function must be a named argument not a positional argument in Python 3). That function appears to be completely unused, so I expect that code never worked. This patch adds the missing key= to that sorted() call, but it would also be reasonable to remove the unused function completely instead.

--- a/test/test_templating.py	Wed Jul 25 00:37:54 2018 +0000
+++ b/test/test_templating.py	Wed Jul 25 00:39:37 2018 +0000
@@ -354,7 +354,12 @@
     def __init__(self, client, classname, nodeid, prop, name, value,
     def __repr__(self):
     def __str__(self):
-    def __cmp__(self, other):
+    def __lt__(self, other):
+    def __le__(self, other):
+    def __eq__(self, other):
+    def __ne__(self, other):
+    def __gt__(self, other):
+    def __ge__(self, other):
     def is_edit_ok(self):
     def is_view_ok(self):
 
@@ -418,8 +423,8 @@
     def field(self, size=30, showid=0):
     def menu(self, size=None, height=None, showid=0, additional=[],
 
-def make_sort_function(db, classname, sort_on=None):
-    def sortfunc(a, b):
+def make_key_function(db, classname, sort_on=None):
+    def keyfunc(a):
 
 def find_sort_key(linkcl):