Mercurial > p > roundup > code
diff doc/upgrading.txt @ 5192:302e3a1a7190
Three sets of changes:
1) Make sure that a user doesn't create a query with the same name
as an existing query that the user owns.
2) When submitting a new named query, display the name of the query
on the index page.
3) Allow optional arguments to indexargs_url by setting their value
to None. This will show the argument only if there is a valid
value.
To match these, changed the template for all search templates so if an
error is thrown due to #1 the user stays on the search page so they
can fix the issue.
Note that I did not add automated tests for these because I couldn't
find existing tests for these code paths that I could adapt. I don't
understand how the existing Action tests work and there is no doc for
them.
| author | rouilj@uland |
|---|---|
| date | Wed, 08 Mar 2017 22:04:15 -0500 |
| parents | 36630a062fb5 |
| children | 3124be3cc197 |
line wrap: on
line diff
--- a/doc/upgrading.txt Sat Feb 25 22:21:15 2017 -0500 +++ b/doc/upgrading.txt Wed Mar 08 22:04:15 2017 -0500 @@ -396,6 +396,24 @@ You do not need to use the ``ctx`` parameter in the function if you do not need it. +Improve query editing +--------------------- + +The query editing interface will now report an error if the user +creates a new query that they are already using. By default the query +editing page (issue.search.html) displays the index page when the +search is triggered. Since the user expects to see the results of the +query, this is usually the right thing. But now that the code properly +checks for duplicate search names, the user should stay on the search +page if there is an error. To add this to your existing +index.search.html page, add the following line after the hidden field +@old-queryname: + + <input type="hidden" name="@template" value="index|search"/> + +With this addition, the index template is displayed if there is no +error, and the user stays on the search template if there is an error. + Migrating from 1.5.0 to 1.5.1 =============================