Mercurial > p > roundup > code
diff CHANGES.txt @ 5192:302e3a1a7190
Three sets of changes:
1) Make sure that a user doesn't create a query with the same name
as an existing query that the user owns.
2) When submitting a new named query, display the name of the query
on the index page.
3) Allow optional arguments to indexargs_url by setting their value
to None. This will show the argument only if there is a valid
value.
To match these, changed the template for all search templates so if an
error is thrown due to #1 the user stays on the search page so they
can fix the issue.
Note that I did not add automated tests for these because I couldn't
find existing tests for these code paths that I could adapt. I don't
understand how the existing Action tests work and there is no doc for
them.
| author | rouilj@uland |
|---|---|
| date | Wed, 08 Mar 2017 22:04:15 -0500 |
| parents | fe52cab8f5b5 |
| children | e0732fd6a6c7 |
line wrap: on
line diff
--- a/CHANGES.txt Sat Feb 25 22:21:15 2017 -0500 +++ b/CHANGES.txt Wed Mar 08 22:04:15 2017 -0500 @@ -378,6 +378,25 @@ - issue2550932 - html_calendar produces templating errors for bad date strings. Fixed to ignore bad date and highlight todays date in the calendar popup. +- Query handling requires that query names for a user are unique. + Different users are allowed to use the same query name. Under some + circumstances a user could generate a second query with the same + name. The SearchAction function has been corrected to report this + error. Also the index.search.html template in the classic tracker + and corresponding templates in the other example trackers + has been modified to include: + <input type="hidden" name="@template" value="index|search"/> + so an error from SearchAction will display an error message and keep + the user on the search page so they can correct the error. See + ``doc/upgrading.txt``. (John Rouillard) +- When a new named search is created, the index page that is displayed + doesn't show the name. This has been fixed by setting the @dispname + to the query's name. (John Rouillard) +- Passing args into indexargs_url(..,{'@queryname': request/dispname + or None, 'Title': 'some' }) where the value of the arg is None + will not add the arg to the url. In the example above @queryname + will only be in the url if dispname is set in the request. + (John Rouillard) 2016-01-11: 1.5.1