Python 3 preparation: update calls to dict methods. Tool-assisted patch. Changes of iterkeys / itervalues / iteritems to keys / values / items are fully automated, but may make things less efficient in Python 2. Automated tools want to add list() around many calls to keys / values / items, but I thought most such list() additions were unnecessary because it seemed the result of keys / values / items was just iterated over while the set of dict keys remained unchanged, rather than used in a way requiring an actual list, or used while the set of keys in the dict could change. It's quite possible I missed some cases where list() was really needed, or left in some unnecessary list() calls. In cases where list() was only needed because the resulting list was then sorted in-place, I changed the code to use calls to sorted().

--- a/roundup/cgi/actions.py	Tue Jul 24 23:03:35 2018 +0000
+++ b/roundup/cgi/actions.py	Tue Jul 24 23:04:42 2018 +0000
@@ -1073,7 +1073,7 @@
 
         # generate the one-time-key and store the props for later
         user_props = props[('user', None)]
-        for propname, proptype in self.db.user.getprops().iteritems():
+        for propname, proptype in self.db.user.getprops().items():
             value = user_props.get(propname, None)
             if value is None:
                 pass