Python 3 preparation: update calls to dict methods. Tool-assisted patch. Changes of iterkeys / itervalues / iteritems to keys / values / items are fully automated, but may make things less efficient in Python 2. Automated tools want to add list() around many calls to keys / values / items, but I thought most such list() additions were unnecessary because it seemed the result of keys / values / items was just iterated over while the set of dict keys remained unchanged, rather than used in a way requiring an actual list, or used while the set of keys in the dict could change. It's quite possible I missed some cases where list() was really needed, or left in some unnecessary list() calls. In cases where list() was only needed because the resulting list was then sorted in-place, I changed the code to use calls to sorted().

--- a/roundup/backends/indexer_common.py	Tue Jul 24 23:03:35 2018 +0000
+++ b/roundup/backends/indexer_common.py	Tue Jul 24 23:04:42 2018 +0000
@@ -40,7 +40,7 @@
             return {}
 
         designator_propname = {}
-        for nm, propclass in klass.getprops().iteritems():
+        for nm, propclass in klass.getprops().items():
             if _isLink(propclass):
                 designator_propname.setdefault(propclass.classname,
                     []).append(nm)
@@ -49,7 +49,7 @@
         # and files
         nodeids = {}      # this is the answer
         propspec = {}     # used to do the klass.find
-        for l in designator_propname.itervalues():
+        for l in designator_propname.values():
             for propname in l:
                 propspec[propname] = {}  # used as a set (value doesn't matter)