diff roundup/backends/rdbms_common.py @ 2228:1d1362c54c94

Some doc / comment fixes. Added tools/load_tracker.py - see its usage string. Used to load a tracker with data for load testing. Preliminary results: sqlite, mysql, postgresql and metakit break *no* sweat with 2000 issues (approx 1700-1800 "open").
author Richard Jones <richard@users.sourceforge.net>
date Tue, 20 Apr 2004 05:47:33 +0000
parents 98d3bf8ffb19
children 70d21059aa18
line wrap: on
line diff
--- a/roundup/backends/rdbms_common.py	Tue Apr 20 00:43:29 2004 +0000
+++ b/roundup/backends/rdbms_common.py	Tue Apr 20 05:47:33 2004 +0000
@@ -1,4 +1,4 @@
-# $Id: rdbms_common.py,v 1.91 2004-04-18 05:31:02 richard Exp $
+# $Id: rdbms_common.py,v 1.92 2004-04-20 05:47:33 richard Exp $
 ''' Relational database (SQL) backend common code.
 
 Basics:
@@ -391,6 +391,9 @@
                 print >>hyperdb.DEBUG, 'create_index', (self, index_sql3)
             self.cursor.execute(index_sql3)
 
+        # TODO: create indexes on (selected?) Link property columns, as
+        # they're more likely to be used for lookup
+
     def drop_class_table_indexes(self, cn, key):
         # drop the old table indexes first
         l = ['_%s_id_idx'%cn, '_%s_retired_idx'%cn]
@@ -1709,8 +1712,6 @@
         None, or a TypeError is raised.  The values of the key property on
         all existing nodes must be unique or a ValueError is raised.
         '''
-        # XXX create an index on the key prop column. We should also 
-        # record that we've created this index in the schema somewhere.
         prop = self.getprops()[propname]
         if not isinstance(prop, String):
             raise TypeError, 'key properties must be String'

Roundup Issue Tracker: http://roundup-tracker.org/