diff test/pytest_patcher.py @ 5111:1c94afabb2cb

Fix mark_class decorator to work in all cases The 'mark_class' decorator assumed that all test functions started with 'test_' which is the common naming convention these days. The roundup codebase predates many of the current common conventions though though, so many tests don't include the underscore. We now correctly check for any test function starting with 'test' and also ensure the 'mark_class' will also work with functions as well as classes. This has been tested will all package dependencies missing, and all the tests correctly skip. All the tests also pass a full test run without any tests being skipped. A smattering of other runs of individual test files and enabled dependencies seem to indicate that all skipping should work as expected now.
author John Kristensen <john@jerrykan.com>
date Thu, 30 Jun 2016 12:38:23 +1000
parents 43a1f7fe39f5
children
line wrap: on
line diff
--- a/test/pytest_patcher.py	Wed Jun 29 18:35:19 2016 -0400
+++ b/test/pytest_patcher.py	Thu Jun 30 12:38:23 2016 +1000
@@ -24,8 +24,11 @@
                                       closure=f.func_closure)
 
     def mark(cls):
+        if isinstance(cls, types.FunctionType):
+            return marker(copy_func(cls))
+
         for method in dir(cls):
-            if method.startswith('test_'):
+            if method.startswith('test'):
                 f = copy_func(getattr(cls, method))
                 setattr(cls, method, marker(f))
         return cls

Roundup Issue Tracker: http://roundup-tracker.org/