Mercurial > p > roundup > code
diff test/test_liveserver.py @ 8268:05d8806b25ad
fix: issue2551387 - TypeError: not indexable.
Fix crash due to uninitialized list element on a (Mini)FieldStorage
when unexpected input is posted via wsgi. This doesn't happen when
running roundup-server. It might happen under other front ends.
Moved the code that sets '.list = [] if .list == None' to the main
flow. Added an exception hander that logs the value of self.form if
self.form.list raises an AttributeError. This exception should never
happen if I understand the code correctly (but I probably don't).
Fixed a number of test cases that were broken because I was calling
Client and passing '[]' rather than a cgi.formStorage object.
Added test cases:
create a FileStorage (self.form) with .list = None.
check AttributeError exception and verify logging.
Problem reported and debugged by Christof Meerwald.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 12 Jan 2025 12:34:52 -0500 |
| parents | 35beff316883 |
| children | c70ffbc2a003 |
line wrap: on
line diff
--- a/test/test_liveserver.py Thu Jan 09 10:14:55 2025 -0500 +++ b/test/test_liveserver.py Sun Jan 12 12:34:52 2025 -0500 @@ -333,6 +333,18 @@ self.assertEqual(cookie._rest['HttpOnly'], None) # flag is present self.assertEqual(cookie._rest['SameSite'], 'Lax') + def test_bad_post_data(self): + """issue2551387 - bad post data causes TypeError: not indexable + """ + session, _response = self.create_login_session() + + h = {"Content-Type": "text/plain"} + response = session.post(self.url_base()+'/', headers=h, data="test") + print(response.status_code) + print(response.headers) + print(response.text) + self.assertEqual(response.status_code, 200) + def test_query(self): current_user_query = ( "@columns=title,id,activity,status,assignedto&"