comparison roundup/cgi/templating.py @ 5548:fea11d05110e

Avoid errors from selecting "no selection" on multilink (issue2550722). As discussed in issue 2550722 there are various cases where selecting "no selection" on a multilink can result in inappropriate errors from Roundup: * If selecting "no selection" produces a null edit (a value was set in the multilink in an edit with an error, then removed again, along with all other changes, in the next form submission), so the page is rendered from the form contents including the "-<id>" value for "no selection" for the multilink. * If creating an item with a nonempty value for a multilink has an error, and the resubmission changes that multilink to "no selection" (and this in turn has subcases, according to whether the creation then succeeds or fails on the resubmission, which need fixes in different places in the Roundup code). All of these cases have in common that it is expected and OK to have a "-<id>" value for a submission for a multilink when <id> is not set in that multilink in the database (because the original attempt to set <id> in that multilink had an error), so the hyperdb.py logic to give an error in that case is thus removed. In the subcase of the second case where the resubmission with "no selection" has an error, the templating code tries to produce a menu entry for the "-<id>" multilink value, which also results in an error, hence the templating.py change to ignore such values in the list for a multilink.
author Joseph Myers <jsm@polyomino.org.uk>
date Thu, 27 Sep 2018 11:33:01 +0000
parents 6b0c542642be
children 97e2125e064c
comparison
equal deleted inserted replaced
5547:081be318661b 5548:fea11d05110e
2393 if not self.is_edit_ok(): 2393 if not self.is_edit_ok():
2394 return self.plain(escape=1) 2394 return self.plain(escape=1)
2395 2395
2396 if value is None: 2396 if value is None:
2397 value = self._value 2397 value = self._value
2398 # When rendering from form contents, 'value' may contain
2399 # elements starting '-' from '- no selection -' having been
2400 # selected on a previous form submission.
2401 value = [v for v in value if not v.startswith('-')]
2398 2402
2399 linkcl = self._db.getclass(self._prop.classname) 2403 linkcl = self._db.getclass(self._prop.classname)
2400 2404
2401 if sort_on is not None: 2405 if sort_on is not None:
2402 if not isinstance(sort_on, tuple): 2406 if not isinstance(sort_on, tuple):

Roundup Issue Tracker: http://roundup-tracker.org/