Mercurial > p > roundup > code
comparison test/test_indexer.py @ 5096:e74c3611b138
- issue2550636, issue2550909: Added support for Whoosh indexer.
Also adds new config.ini setting called indexer to select
indexer. See ``doc/upgrading.txt`` for details. Initial patch
done by David Wolever. Patch modified (see ticket or below for
changes), docs updated and committed.
I have an outstanding issue with test/test_indexer.py. I have to
comment out all imports and tests for indexers I don't have (i.e.
mysql, postgres) otherwise no tests run.
With that change made, dbm, sqlite (rdbms), xapian and whoosh indexes
are all passing the indexer tests.
Changes summary:
1) support native back ends dbm and rdbms. (original patch only fell
through to dbm)
2) Developed whoosh stopfilter to not index stopwords or words outside
the the maxlength and minlength limits defined in index_common.py.
Required to pass the extremewords test_indexer test. Also I
removed a call to .lower on the input text as the tokenizer I chose
automatically does the lowercase.
3) Added support for max/min length to find. This was needed to pass
extremewords test.
4) Added back a call to save_index in add_text. This allowed all but
two tests to pass.
5) Fixed a call to:
results = searcher.search(query.Term("identifier", identifier))
which had an extra parameter that is an error under current whoosh.
6) Set limit=None in search call for find() otherwise it only return
10 items. This allowed it to pass manyresults test
Also due to changes in the roundup code removed the call in
indexer_whoosh to
from roundup.anypy.sets_ import set
since we use the python builtin set.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 25 Jun 2016 20:10:03 -0400 |
| parents | c977f3530944 |
| children | 37d1e24fb941 |
comparison
equal
deleted
inserted
replaced
| 5095:d3ba0b254dbb | 5096:e74c3611b138 |
|---|---|
| 37 skip_xapian = lambda func, *args, **kwargs: func | 37 skip_xapian = lambda func, *args, **kwargs: func |
| 38 except ImportError: | 38 except ImportError: |
| 39 skip_xapian = pytest.skip( | 39 skip_xapian = pytest.skip( |
| 40 "Skipping Xapian indexer tests: 'xapian' not installed") | 40 "Skipping Xapian indexer tests: 'xapian' not installed") |
| 41 | 41 |
| 42 try: | |
| 43 import whoosh | |
| 44 skip_whoosh = lambda func, *args, **kwargs: func | |
| 45 except ImportError: | |
| 46 skip_whoosh = pytest.skip( | |
| 47 "Skipping Whoosh indexer tests: 'whoosh' not installed") | |
| 42 | 48 |
| 43 class db: | 49 class db: |
| 44 class config(dict): | 50 class config(dict): |
| 45 DATABASE = 'test-index' | 51 DATABASE = 'test-index' |
| 46 config = config() | 52 config = config() |
| 148 self.assertEqual(len(self.dex.find(['many'])), 123) | 154 self.assertEqual(len(self.dex.find(['many'])), 123) |
| 149 | 155 |
| 150 def tearDown(self): | 156 def tearDown(self): |
| 151 shutil.rmtree('test-index') | 157 shutil.rmtree('test-index') |
| 152 | 158 |
| 159 @skip_whoosh | |
| 160 class WhooshIndexerTest(IndexerTest): | |
| 161 def setUp(self): | |
| 162 if os.path.exists('test-index'): | |
| 163 shutil.rmtree('test-index') | |
| 164 os.mkdir('test-index') | |
| 165 from roundup.backends.indexer_whoosh import Indexer | |
| 166 self.dex = Indexer(db) | |
| 167 def tearDown(self): | |
| 168 shutil.rmtree('test-index') | |
| 153 | 169 |
| 154 @skip_xapian | 170 @skip_xapian |
| 155 class XapianIndexerTest(IndexerTest): | 171 class XapianIndexerTest(IndexerTest): |
| 156 def setUp(self): | 172 def setUp(self): |
| 157 if os.path.exists('test-index'): | 173 if os.path.exists('test-index'): |