Mercurial > p > roundup > code
comparison roundup/backends/back_mysql.py @ 6593:e70e2789bc2c
issue2551189 - increase text search maxlength
This removes I think all the magic references to 25 and 30 (varchar
size) and replaces them with references to maxlength or maxlength+5.
I am not sure why the db column is 5 characters larger than the size
of what should be the max size of a word, but I'll keep the buffer
of 5 as making it 1/5 the size of maxlength makes less sense.
Also added tests for fts search in templating which were missing.
Added postgres, mysql and sqlite native indexing backends in which to
test fts. Added fts test to native-fts as well to make sure it's
working.
I want to commit this now for CI.
Todo:
add test cases for the use of FTS in the csv output in
actions.py. There is no test coverage of the match case there.
change maxlength to a higher value (50) as requested in the ticket.
Modify existing extremewords test cases to allow words > 25 and < 51
write code to migrate column sizes for mysql and postgresql to match
maxlength I will roll this into the version 7 schema update that
supports use of database fts support.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 25 Jan 2022 13:22:00 -0500 |
| parents | c1d3fbcdbfbd |
| children | 39189dd94f2c |
comparison
equal
deleted
inserted
replaced
| 6592:828e2eaee7cd | 6593:e70e2789bc2c |
|---|---|
| 232 | 232 |
| 233 # full-text indexing store | 233 # full-text indexing store |
| 234 self.sql('''CREATE TABLE __textids (_class VARCHAR(255), | 234 self.sql('''CREATE TABLE __textids (_class VARCHAR(255), |
| 235 _itemid VARCHAR(255), _prop VARCHAR(255), _textid INT) | 235 _itemid VARCHAR(255), _prop VARCHAR(255), _textid INT) |
| 236 ENGINE=%s'''%self.mysql_backend) | 236 ENGINE=%s'''%self.mysql_backend) |
| 237 self.sql('''CREATE TABLE __words (_word VARCHAR(30), | 237 self.sql('''CREATE TABLE __words (_word VARCHAR(%s), |
| 238 _textid INT) ENGINE=%s'''%self.mysql_backend) | 238 _textid INT) ENGINE=%s''' % ((self.indexer.maxlength + 5), |
| 239 self.mysql_backend) | |
| 240 ) | |
| 239 self.sql('CREATE INDEX words_word_ids ON __words(_word)') | 241 self.sql('CREATE INDEX words_word_ids ON __words(_word)') |
| 240 self.sql('CREATE INDEX words_by_id ON __words (_textid)') | 242 self.sql('CREATE INDEX words_by_id ON __words (_textid)') |
| 241 self.sql('CREATE UNIQUE INDEX __textids_by_props ON ' | 243 self.sql('CREATE UNIQUE INDEX __textids_by_props ON ' |
| 242 '__textids (_class, _itemid, _prop)') | 244 '__textids (_class, _itemid, _prop)') |
| 243 sql = 'insert into ids (name, num) values (%s,%s)'%(self.arg, self.arg) | 245 sql = 'insert into ids (name, num) values (%s,%s)'%(self.arg, self.arg) |