Mercurial > p > roundup > code
comparison CHANGES.txt @ 7690:d17e57220a62 2.3.1a0
fix: close file properly in indexer_dbm.py:save_index()
Fix this error found in debug logs of gentoo packaging of round 2.2.0.
/roundup/backends/indexer_dbm.py:253: ResourceWarning: unclosed file
<_io.BufferedWriter name='test-index/indexes/index.db-'>
open(self.indexdb+'-', 'wb').write(zlib.compress(marshal.dumps(dbfil)))
Also added test that calls save_index(), reloads the index and tests
that the original item. I am not sure how Gentoo hit
this But they were missing a number of backends. So it's possible that
indexer_dbm.py is not getting fully tested depending on what is
installed on the system. Codecov from CI didnt show
indexer_dbm.py:save_index() being covered.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 02 Nov 2023 18:55:47 -0400 |
| parents | a27f30709d46 |
| children | 78585199552a 54eb12cd3be1 |
comparison
equal
deleted
inserted
replaced
| 7689:29dba38a852a | 7690:d17e57220a62 |
|---|---|
| 71 newer. dicttoxml uses a type alias: collection.Iterator that is | 71 newer. dicttoxml uses a type alias: collection.Iterator that is |
| 72 dropped in Python 3.10. (found by Norbert SCHLEMMER, fix John | 72 dropped in Python 3.10. (found by Norbert SCHLEMMER, fix John |
| 73 Rouillard) | 73 Rouillard) |
| 74 - fix repeated password id with user.item.html in all templates except | 74 - fix repeated password id with user.item.html in all templates except |
| 75 jinja2. (John Rouillard) | 75 jinja2. (John Rouillard) |
| 76 - fix unclosed file when saving index in indexer_dbm.py. (John Rouillard) | |
| 76 | 77 |
| 77 Features: | 78 Features: |
| 78 | 79 |
| 79 - issue2551103 - add pragma 'display_protected' to roundup-admin. If | 80 - issue2551103 - add pragma 'display_protected' to roundup-admin. If |
| 80 true, print protected attributes like id, activity, actor... | 81 true, print protected attributes like id, activity, actor... |