Mercurial > p > roundup > code
comparison roundup/backends/back_postgresql.py @ 6433:c1d3fbcdbfbd
issue2551142 - Import of retired node ... unique constraint failure.
Title: Import of retired node with username after active node fails
with unique constraint failure.
More fixes needed for mysql and postgresql.
mysql: add unique constraint for (keyvalue, __retired__) when
creating class in the database.
On schema change if class is changed, remove the unique
constraint too.
upgrade version of rdbms database from 5 to 6 to add constraint
to all version 5 databases that were created as version 5
and didn't get the unique constraint. Make no changes
on version 5 databases upgraded from version 4, the upgrade
process to 5 added the constraint. Make no changes
to other databases (sqlite, postgres) during upgrade from
version 5 to 6.
postgres: Handle the exception raised on unique constraint violation.
The exception invalidates the database connection so it
can't be used to recover from the exception.
Added two new database methods:
checkpoint_data - performs a db.commit under postgres
does nothing on other backends
restore_connection_on_error - does a db.rollback on
postgres, does nothing on other
backends
with the rollback() done on the connection I can use the
database connection to fixup the import that failed on the
unique constraint. This makes postgres slower but without the
commit after every imported object, the rollback will delete
all the entries done up to this point.
Trying to figure out how to make the caller do_import batch
and recover from this failure is beyond me.
Also dismissed having to process the export csv file before
importing. Pushing that onto a user just seems wrong. Also
since import/export isn't frequently done the lack of
surprise on having a failing import and reduced
load/frustration for the user seems worth it. Also the import
can be run in verbose mode where it prints out a row as it is
processed, so it may take a while, ut the user can get
feedback.
db_test-base.py: add test for upgrade from 5 to 6.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 10 Jun 2021 12:52:05 -0400 |
| parents | 6a6b4651be1f |
| children | 4f8fc55730e1 |
comparison
equal
deleted
inserted
replaced
| 6432:97a45bfa62a8 | 6433:c1d3fbcdbfbd |
|---|---|
| 198 self.create_version_2_tables() | 198 self.create_version_2_tables() |
| 199 # Need to commit here, otherwise otk/session will not find | 199 # Need to commit here, otherwise otk/session will not find |
| 200 # the necessary tables (in a parallel connection!) | 200 # the necessary tables (in a parallel connection!) |
| 201 self.commit() | 201 self.commit() |
| 202 | 202 |
| 203 def checkpoint_data(self): | |
| 204 """Commit the state of the database. Allows recovery/retry | |
| 205 of operation in exception handler because postgres | |
| 206 requires a rollback in case of error generating exception | |
| 207 """ | |
| 208 self.commit() | |
| 209 | |
| 210 def restore_connection_on_error(self): | |
| 211 """Postgres leaves a cursor in an unusable state after | |
| 212 an error. Rollback the transaction to recover and | |
| 213 permit a retry of the failed statement. Used with | |
| 214 checkpoint_data to handle uniqueness conflict in | |
| 215 import_table() | |
| 216 """ | |
| 217 self.rollback() | |
| 218 | |
| 203 def create_version_2_tables(self): | 219 def create_version_2_tables(self): |
| 204 # OTK store | 220 # OTK store |
| 205 self.sql('''CREATE TABLE otks (otk_key VARCHAR(255), | 221 self.sql('''CREATE TABLE otks (otk_key VARCHAR(255), |
| 206 otk_value TEXT, otk_time REAL)''') | 222 otk_value TEXT, otk_time REAL)''') |
| 207 self.sql('CREATE INDEX otks_key_idx ON otks(otk_key)') | 223 self.sql('CREATE INDEX otks_key_idx ON otks(otk_key)') |