Mercurial Repository: p/roundup/code: test/db_test

comparison test/db_test_base.py @ 5112:8901cc4ef0e0

- issue1714899: Feature Request: Optional Change Note. Added a new quiet=True/False option for all property types. When quiet=True changes to the property will not be displayed in the:: confirmation banner (shown in green) when a change is made property change section of change note (nosy emails) web history display for an item. Note that this may confuse users if used on a property that is meant to be changed by a user. It is most useful on administrative properties that are changed by an auditor as part of a user generated change. Original patch by Daniel Diniz (ajaksu2) discussed also at: http://psf.upfronthosting.co.za/roundup/meta/issue249 Support for setting quiet when calling the class specifiers: E.G. prop=String(quiet=True) rather than:: prop=String() prop.quiet=True support for anydb backend, added tests, doc updates, support for ignoring quiet setting using showall=True in call to history() function in templates by John Rouillard. In addition to documenting quiet, I also documented required and default_value additions to the hyperdb property classes. Only place I could find is design.txt. Note tests for history in web interface are not done. It was manually checked but there are no automated tests. The template for setup is in db_test_base.py::testQuietJournal but it has no asserts. I need access to template.py::_HTMLItem::history() and I don't know how to do that. test_templates.py isn't helping me any at all and I want to get this patch in because it handles nicely an issue I have in the design of my own tracker. The issue is: The properties of an issue are displayed in framesets/subframes. The user can roll up the frameset leaving only the title bar. When the user saves the changes, the current state of the framesets (collapsed/uncollapsed) is saved to a property in the user's object. However there is no reason the user should see that this is updated since it's an administrative detail. Similarly, you could count the number of times an issue is reopened or reassigned. Updates to properties that are an indirect result of a user's change should not be displayed to the user as they can be confusing and distracting.

author	John Rouillard <rouilj@ieee.org>
date	Thu, 30 Jun 2016 20:38:23 -0400
parents	87b0358790ed
children	e098536107ea

comparison

equal deleted inserted replaced

-:1c94afabb2cb
+:8901cc4ef0e0
 mls.setkey("name")
 status = module.Class(db, "status", name=String(), mls=Multilink("mls"))
 status.setkey("name")
 priority = module.Class(db, "priority", name=String(), order=String())
 priority.setkey("name")
-user = module.Class(db, "user", username=String(), password=Password(),
+user = module.Class(db, "user", username=String(), password=Password(quiet=True),
-assignable=Boolean(), age=Number(), roles=String(), address=String(),
+assignable=Boolean(quiet=True), age=Number(quiet=True), roles=String(), address=String(),
-rating=Integer(), supervisor=Link('user'),realname=String())
+rating=Integer(quiet=True), supervisor=Link('user'),realname=String(quiet=True))
 user.setkey("username")
 file = module.FileClass(db, "file", name=String(), type=String(),
 comment=String(indexme="yes"), fooz=Password())
 file_nidx = module.FileClass(db, "file_nidx", content=String(indexme='no'))
+# initialize quiet mode a second way without using Multilink("user", quiet=True)
+mynosy = Multilink("user")
+mynosy.quiet = True
 issue = module.IssueClass(db, "issue", title=String(indexme="yes"),
-status=Link("status"), nosy=Multilink("user"), deadline=Date(),
+status=Link("status"), nosy=mynosy, deadline=Date(quiet=True),
-foo=Interval(), files=Multilink("file"), assignedto=Link('user'),
+foo=Interval(quiet=True, default_value=date.Interval('-1w')), files=Multilink("file"), assignedto=Link('user', quiet=True),
 priority=Link('priority'), spam=Multilink('msg'),
 feedback=Link('msg'))
 stuff = module.Class(db, "stuff", stuff=String())
 session = module.Class(db, 'session', title=String())
 msg = module.FileClass(db, "msg", date=Date(),
 self.db.user.audit('create', test.c, 2)
 self.db.user.create(username="mary")
 self.assertEqual(test.call_a, 0)
 self.assertEqual(test.call_b, 1)
 self.assertEqual(test.call_c, 2)
+def testDefault_Value(self):
+new_issue=self.db.issue.create(title="title", deadline=date.Date('2016-6-30.22:39'))
+# John Rouillard claims this should return the default value of 1 week for foo,
+# but the hyperdb doesn't assign the default value for missing properties in the
+# db on creation.
+result=self.db.issue.get(new_issue, 'foo')
+# When the defaultis automatically set by the hyperdb, change this to
+# match the Interval test below.
+self.assertEqual(result, None)
+# but verify that the default value is retreivable
+result=self.db.issue.properties['foo'].get_default_value()
+self.assertEqual(result, date.Interval('-7d'))
+def testQuietProperty(self):
+# make sure that the quiet properties: "assignable" and "age" are not
+# returned as part of the proplist
+new_user=self.db.user.create(username="pete", age=10, assignable=False)
+new_issue=self.db.issue.create(title="title", deadline=date.Date('2016-6-30.22:39'))
+# change all quiet params. Verify they aren't returned in object.
+# between this and the issue class every type represented in hyperdb
+# should be initalized with a quiet parameter.
+result=self.db.user.set(new_user, username="new", age=20, supervisor='3', assignable=True,
+password=password.Password("3456"), rating=4, realname="newname")
+self.assertEqual(result, {'supervisor': '3', 'username': "new"})
+result=self.db.user.get(new_user, 'age')
+self.assertEqual(result, 20)
+# change all quiet params. Verify they aren't returned in object.
+result=self.db.issue.set(new_issue, title="title2", deadline=date.Date('2016-7-13.22:39'),
+assignedto="2", nosy=["3", "2"])
+self.assertEqual(result, {'title': 'title2'})
+# also test that we can make a property noisy
+self.db.user.properties['age'].quiet=False
+result=self.db.user.set(new_user, username="old", age=30, supervisor='2', assignable=False)
+self.assertEqual(result, {'age': 30, 'supervisor': '2', 'username': "old"})
+self.db.user.properties['age'].quiet=True
+def testQuietChangenote(self):
+# create user 3 for later use
+self.db.user.create(username="pete", age=10, assignable=False)
+new_issue=self.db.issue.create(title="title", deadline=date.Date('2016-6-30.22:39'))
+# change all quiet params. Verify they aren't returned in CreateNote.
+result=self.db.issue.set(new_issue, title="title2", deadline=date.Date('2016-6-30.22:39'),
+assignedto="2", nosy=["3", "2"])
+result=self.db.issue.generateCreateNote(new_issue)
+self.assertEqual(result, '\n----------\ntitle: title2')
+# also test that we can make a property noisy
+self.db.issue.properties['nosy'].quiet=False
+self.db.issue.properties['deadline'].quiet=False
+result=self.db.issue.set(new_issue, title="title2", deadline=date.Date('2016-7-13.22:39'),
+assignedto="2", nosy=["1", "2"])
+result=self.db.issue.generateCreateNote(new_issue)
+self.assertEqual(result, '\n----------\ndeadline: 2016-07-13.22:39:00\nnosy: admin, fred\ntitle: title2')
+self.db.issue.properties['nosy'].quiet=True
+self.db.issue.properties['deadline'].quiet=True
+def testQuietJournal(self):
+# FIXME this doesn't work. I need to call
+# template.py::_HTMLItem::history() and verify the output.
+# not sure how to get there from here. -- rouilj
+# make sure that the quiet properties: "assignable" and "age" are not
+# returned as part of the journal
+#   so comment out tests here but leave framework for later.
+new_user=self.db.user.create(username="pete", age=10, assignable=False)
+new_issue=self.db.issue.create(title="title", deadline=date.Date('2016-6-30.22:39'))
+# change all quiet params. Verify they aren't returned in journal.
+# between this and the issue class every type represented in hyperdb
+# should be initalized with a quiet parameter.
+result=self.db.user.set(new_user, username="new", age=20, supervisor='3', assignable=True,
+password=password.Password("3456"), rating=4, realname="newname")
+result=self.db.user.history(new_user)
+#self.assertEqual(result, 20)
+# change all quiet params. Verify they aren't returned in object.
+result=self.db.issue.set(new_issue, title="title2", deadline=date.Date('2016-6-30.22:39'),
+assignedto="2", nosy=["3", "2"])
+result=self.db.issue.generateCreateNote(new_issue)
+#self.assertEqual(result, '\n----------\ntitle: title2')
+# also test that we can make a property noisy
+self.db.issue.properties['nosy'].quiet=False
+self.db.issue.properties['deadline'].quiet=False
+result=self.db.issue.set(new_issue, title="title2", deadline=date.Date('2016-7-13.22:39'),
+assignedto="2", nosy=["1", "2"])
+result=self.db.issue.generateCreateNote(new_issue)
+#self.assertEqual(result, '\n----------\ndeadline: 2016-07-13.22:39:00\nnosy: admin, fred\ntitle: title2')
+self.db.issue.properties['nosy'].quiet=True
+self.db.issue.properties['deadline'].quiet=True
 def testJournals(self):
 muid = self.db.user.create(username="mary")
 self.db.user.create(username="pete")
 self.db.issue.create(title="spam", status='1')

Mercurial > p > roundup > code

comparison test/db_test_base.py @ 5112:8901cc4ef0e0