Mercurial Repository: p/roundup/code: test/test

comparison test/test_mailgw.py @ 4781:6e9b9743de89

Implementation for: http://issues.roundup-tracker.org/issue2550731 Add mechanism for the detectors to be able to tell the source of the data changes. Support for tx_Source property on database handle. Can be used by detectors to find out the source of a change in an auditor to block changes arriving by unauthenticated mechanisms (e.g. plain email where headers can be faked). The property db.tx_Source has the following values: * None - Default value set to None. May be valid if it's a script that is created by the user. Otherwise it's an error and indicates that some code path is not properly setting the tx_Source property. * "cli" - this string value is set when using roundup-admin and supplied scripts. * "web" - this string value is set when using any web based technique: html interface, xmlrpc .... * "email" - this string value is set when using an unauthenticated email based technique. * "email-sig-openpgp" - this string value is set when email with a valid pgp signature is used. (*NOTE* the testing for this mode is incomplete. If you have a pgp infrastructure you should test and verify that this is properly set.) This also includes some (possibly incomplete) tests cases for the modes above and an example of using ts_Source in the customization.txt document.

author	John Rouillard <rouilj@ieee.org>
date	Tue, 23 Apr 2013 23:06:09 -0400
parents	782737d1a2d7
children	a850f8bae536

comparison

equal deleted inserted replaced

-:3adff0fb0207
+:6e9b9743de89
 res.append('- %s'%l1[i])
 res.append('+ %s'%l2[j])
 return res
+from roundup.hyperdb import String
 class MailgwTestAbstractBase(unittest.TestCase, DiffHelper):
 count = 0
 schema = 'classic'
 def setUp(self):
 self.old_translate_ = mailgw._
 roundupdb._ = mailgw._ = i18n.get_translation(language='C').gettext
 self.__class__.count = self.__class__.count + 1
 # and open the database / "instance"
 self.db = memorydb.create('admin')
+self.db.issue.addprop(tx_Source=String())
+self.db.msg.addprop(tx_Source=String())
+self.db.post_init()
+self.db.tx_Source = "email"
 self.instance = Tracker()
 self.instance.db = self.db
 self.instance.config = self.db.config
 self.instance.MailGW = MailGW
 Subject: [issue] Testing...
 ''')
 assert not os.path.exists(SENDMAILDEBUG)
 self.assertEqual(self.db.issue.get(nodeid, 'title'), 'Testing...')
+self.assertEqual(self.db.issue.get(nodeid, 'tx_Source'), 'email')
 class MailgwTestCase(MailgwTestAbstractBase):
 def testMessageWithFromInIt(self):
 nodeid = self._handle_mail(self.newmsg)
 assert not os.path.exists(SENDMAILDEBUG)
 l = self.db.issue.get(nodeid, 'nosy')
 l.sort()
 self.assertEqual(l, [self.chef_id, self.richard_id])
+# check that the message has the right source code
+l = self.db.msg.get('1', 'tx_Source')
+self.assertEqual(l, 'email')
 return nodeid
 def testNewIssue(self):
 self.doNewIssue()
 assignedto: richard
 messages: 1
 nosy: Chef, mary, richard
 status: unread
 title: Testing...
+tx_Source: email
 _______________________________________________________________________
 Roundup issue tracker <issue_tracker@your.tracker.email.domain.example>
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
 _______________________________________________________________________
 assignedto: richard
 messages: 1
 nosy: Chef, mary, richard
 status: unread
 title: Testing...
+tx_Source: email
 _______________________________________________________________________
 Roundup issue tracker <issue_tracker@your.tracker.email.domain.example>
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
 _______________________________________________________________________
 assignedto: richard
 messages: 1
 nosy: Chef, mary, richard
 status: unread
 title: Testing...
+tx_Source: email
 _______________________________________________________________________
 Roundup issue tracker <issue_tracker@your.tracker.email.domain.example>
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
 _______________________________________________________________________
 X-Roundup-Name: Roundup issue tracker
 X-Roundup-Loop: hello
 X-Roundup-Issue-Status: chatting
 Content-Transfer-Encoding: quoted-printable
 richard <richard@test.test> added the comment:
 This is a followup
 ----------
 ''')
 l = self.db.issue.get('1', 'nosy')
 l.sort()
 self.assertEqual(l, [self.chef_id, self.richard_id, self.mary_id,
 self.john_id])
+# check that the message has the right tx_Source
+l = self.db.msg.get('2', 'tx_Source')
+self.assertEqual(l, 'email')
 self.compareMessages(self._get_mail(),
 '''FROM: roundup-admin@your.tracker.email.domain.example
 TO: chef@bork.bork.bork, john@test.test, mary@test.test
 Content-Type: text/plain; charset="utf-8"
 X-Roundup-Name: Roundup issue tracker
 X-Roundup-Loop: hello
 X-Roundup-Issue-Status: chatting
 Content-Transfer-Encoding: quoted-printable
 richard <richard@test.test> added the comment:
 This is a followup
 ----------
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
 _______________________________________________________________________
 ''')
 def testNosyGeneration(self):
+self.db.tx_Source = "email"
 self.db.issue.create(title='test')
 # create a nosy message
 msg = self.db.msg.create(content='This is a test',
 author=self.richard_id, messageid='<dummy_test_message_id>')
 self.db.journaltag = 'richard'
 l = self.db.issue.create(title='test', messages=[msg],
 nosy=[self.chef_id, self.mary_id, self.john_id])
+# check that message has right tx_Source
+self.assertEqual(self.db.msg.get('1', 'tx_Source'), 'email')
 self.compareMessages(self._get_mail(),
 '''FROM: roundup-admin@your.tracker.email.domain.example
 TO: chef@bork.bork.bork, john@test.test, mary@test.test
 Content-Type: text/plain; charset="utf-8"
 ----------
 messages: 1
 nosy: Chef, john, mary, richard
 status: unread
 title: test
+tx_Source: email
 _______________________________________________________________________
 Roundup issue tracker <issue_tracker@your.tracker.email.domain.example>
 <http://tracker.example/cgi-bin/roundup.cgi/bugs/issue2>
 _______________________________________________________________________
 Message-Id: <followup_dummy_id>
 Subject: Re: Testing... [assignedto=mary; nosy=+john]
 This is a followup
 ''')
+l = self.db.msg.get('2', 'tx_Source')
+self.assertEqual(l, 'email')
 self.compareMessages(self._get_mail(),
 '''FROM: roundup-admin@your.tracker.email.domain.example
 TO: chef@bork.bork.bork, john@test.test, mary@test.test
 Content-Type: text/plain; charset="utf-8"
 Subject: [issue1] Testing...
 def testPGPSignedMessage(self):
 nodeid = self._handle_mail(self.signed_msg)
 m = self.db.issue.get(nodeid, 'messages')[0]
 self.assertEqual(self.db.msg.get(m, 'content'),
 'This is a pgp signed message.')
+# check that the message has the right source code
+l = self.db.msg.get(m, 'tx_Source')
+self.assertEqual(l, 'email-sig-openpgp')
 def testPGPSignedMessageFail(self):
 # require both, signing and encryption
 self.instance.config['PGP_REQUIRE_INCOMING'] = 'both'
 self.assertRaises(MailUsageError, self._handle_mail, self.signed_msg)
 self.instance.config['PGP_REQUIRE_INCOMING'] = 'encrypted'
 nodeid = self._handle_mail (self.encrypted_msg)
 m = self.db.issue.get(nodeid, 'messages')[0]
 self.assertEqual(self.db.msg.get(m, 'content'),
 'This is the text to be encrypted')
+# check that the message has the right source code
+l = self.db.msg.get(m, 'tx_Source')
+self.assertEqual(l, 'email')
 def testPGPEncryptedUnsignedMessageFromNonPGPUser(self):
 msg = self.encrypted_msg.replace('John Doe <john@test.test>',
 '"Contrary, Mary" <mary@test.test>')
 nodeid = self._handle_mail (msg)
 m = self.db.issue.get(nodeid, 'messages')[0]
 self.assertEqual(self.db.msg.get(m, 'content'),
 'This is the text to be encrypted')
 self.assertEqual(self.db.msg.get(m, 'author'), self.mary_id)
+# check that the message has the right source code
+l = self.db.msg.get(m, 'tx_Source')
+self.assertEqual(l, 'email')
 # check that a bounce-message that is triggered *after*
 # decrypting is properly encrypted:
 def testPGPEncryptedUnsignedMessageCheckBounce(self):
 # allow non-signed msg
 --ReaqsoxgOBHFXBhH--
 ''')
 m = self.db.issue.get(nodeid, 'messages')[0]
 self.assertEqual(self.db.msg.get(m, 'content'),
 'This is the text of a signed and encrypted email.')
+# check that the message has the right source code
+l = self.db.msg.get(m, 'tx_Source')
+self.assertEqual(l, 'email-sig-openpgp')
 def test_suite():
 suite = unittest.TestSuite()
 suite.addTest(unittest.makeSuite(MailgwTestCase))
 if pyme is not None:

Mercurial > p > roundup > code

comparison test/test_mailgw.py @ 4781:6e9b9743de89