Mercurial > p > roundup > code

comparison test/rest_common.py @ 6350:6a69584d117e

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove length checks. We check list content explicitly. So the length checks are redundant.
author John Rouillard <rouilj@ieee.org>
date Sat, 27 Mar 2021 11:55:19 -0400
parents ec853cef2f09
children 58817c3bf471
comparison
equal deleted inserted replaced
6349:c1a672b1ad85 6350:6a69584d117e
2971 2971
2972 # verify the result 2972 # verify the result
2973 results = self.server.get_element('issue', issue_id, self.terse_form) 2973 results = self.server.get_element('issue', issue_id, self.terse_form)
2974 results = results['data'] 2974 results = results['data']
2975 self.assertEqual(self.dummy_client.response_code, 200) 2975 self.assertEqual(self.dummy_client.response_code, 200)
2976 self.assertEqual(len(results['attributes']['nosy']), 2)
2977 self.assertListEqual(results['attributes']['nosy'], ['1', '2']) 2976 self.assertListEqual(results['attributes']['nosy'], ['1', '2'])
2978 2977
2979 etag = calculate_etag(self.db.issue.getnode(issue_id), 2978 etag = calculate_etag(self.db.issue.getnode(issue_id),
2980 self.db.config['WEB_SECRET_KEY']) 2979 self.db.config['WEB_SECRET_KEY'])
2981 form = cgi.FieldStorage() 2980 form = cgi.FieldStorage()
2989 2988
2990 # verify the result 2989 # verify the result
2991 results = self.server.get_element('issue', issue_id, self.terse_form) 2990 results = self.server.get_element('issue', issue_id, self.terse_form)
2992 results = results['data'] 2991 results = results['data']
2993 self.assertEqual(self.dummy_client.response_code, 200) 2992 self.assertEqual(self.dummy_client.response_code, 200)
2994 self.assertEqual(len(results['attributes']['nosy']), 3)
2995 self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3']) 2993 self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3'])
2994
2996 2995
2997 # patch with no new_val/data 2996 # patch with no new_val/data
2998 etag = calculate_etag(self.db.issue.getnode(issue_id), 2997 etag = calculate_etag(self.db.issue.getnode(issue_id),
2999 self.db.config['WEB_SECRET_KEY']) 2998 self.db.config['WEB_SECRET_KEY'])
3000 form = cgi.FieldStorage() 2999 form = cgi.FieldStorage()
3008 3007
3009 # verify the result 3008 # verify the result
3010 results = self.server.get_element('issue', issue_id, self.terse_form) 3009 results = self.server.get_element('issue', issue_id, self.terse_form)
3011 results = results['data'] 3010 results = results['data']
3012 self.assertEqual(self.dummy_client.response_code, 200) 3011 self.assertEqual(self.dummy_client.response_code, 200)
3013 self.assertEqual(len(results['attributes']['nosy']), 3)
3014 self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3']) 3012 self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3'])
3015 3013
3016 # patch invalid property 3014 # patch invalid property
3017 etag = calculate_etag(self.db.issue.getnode(issue_id), 3015 etag = calculate_etag(self.db.issue.getnode(issue_id),
3018 self.db.config['WEB_SECRET_KEY']) 3016 self.db.config['WEB_SECRET_KEY'])
3055 self.assertEqual(self.dummy_client.response_code, 412) 3053 self.assertEqual(self.dummy_client.response_code, 412)
3056 results = self.server.get_element('issue', issue_id, self.terse_form) 3054 results = self.server.get_element('issue', issue_id, self.terse_form)
3057 results = results['data'] 3055 results = results['data']
3058 self.assertEqual(self.dummy_client.response_code, 200) 3056 self.assertEqual(self.dummy_client.response_code, 200)
3059 self.assertEqual(results['attributes']['status'], '1') 3057 self.assertEqual(results['attributes']['status'], '1')
3060 self.assertEqual(len(results['attributes']['nosy']), 1)
3061 self.assertListEqual(results['attributes']['nosy'], ['1']) 3058 self.assertListEqual(results['attributes']['nosy'], ['1'])
3062 3059
3063 # replace userid 2 to the nosy list and status = 3 3060 # replace userid 2 to the nosy list and status = 3
3064 etag = calculate_etag(self.db.issue.getnode(issue_id), 3061 etag = calculate_etag(self.db.issue.getnode(issue_id),
3065 self.db.config['WEB_SECRET_KEY']) 3062 self.db.config['WEB_SECRET_KEY'])
3075 # verify the result 3072 # verify the result
3076 results = self.server.get_element('issue', issue_id, self.terse_form) 3073 results = self.server.get_element('issue', issue_id, self.terse_form)
3077 results = results['data'] 3074 results = results['data']
3078 self.assertEqual(self.dummy_client.response_code, 200) 3075 self.assertEqual(self.dummy_client.response_code, 200)
3079 self.assertEqual(results['attributes']['status'], '3') 3076 self.assertEqual(results['attributes']['status'], '3')
3080 self.assertEqual(len(results['attributes']['nosy']), 1)
3081 self.assertListEqual(results['attributes']['nosy'], ['2']) 3077 self.assertListEqual(results['attributes']['nosy'], ['2'])
3082 3078
3083 # replace status = 2 using status attribute 3079 # replace status = 2 using status attribute
3084 etag = calculate_etag(self.db.issue.getnode(issue_id), 3080 etag = calculate_etag(self.db.issue.getnode(issue_id),
3085 self.db.config['WEB_SECRET_KEY']) 3081 self.db.config['WEB_SECRET_KEY'])
Roundup Issue Tracker: http://roundup-tracker.org/