Mercurial > p > roundup > code
comparison website/issues/html/issue.item.html @ 8356:63390dcfcfe9
bug: fix template use of structure with untrusted data
Looks like an xSS bug with an early version of the template that was
fixed in the code but never in the deployed tracker. It has been a
while since this particular construct has been in the classic template
which is the base for the tracker.
This has been fixed on the deployed tracker as well.
reported by 4bug of ChaMd5 Security Team H1 Group
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 08 Jul 2025 10:23:09 -0400 |
| parents | 12c5ddf865b1 |
| children | abf1297e7a94 |
comparison
equal
deleted
inserted
replaced
| 8355:226a4f391ae2 | 8356:63390dcfcfe9 |
|---|---|
| 43 <tr> | 43 <tr> |
| 44 <th class="required"><label for="title" i18n:translate="">Title:</label></th> | 44 <th class="required"><label for="title" i18n:translate="">Title:</label></th> |
| 45 <td colspan="3" tal:condition="context/title/is_edit_ok" | 45 <td colspan="3" tal:condition="context/title/is_edit_ok" |
| 46 tal:content="structure python:context.title.field(id='title', size=60)">title</td> | 46 tal:content="structure python:context.title.field(id='title', size=60)">title</td> |
| 47 <td colspan="3" tal:condition="not:context/title/is_edit_ok"> | 47 <td colspan="3" tal:condition="not:context/title/is_edit_ok"> |
| 48 <span tal:content="structure context/title/plain"/> | 48 <span tal:content="context/title/plain"/> |
| 49 <input type="hidden" name="title" tal:attributes="value context/title"> | 49 <input type="hidden" name="title" tal:attributes="value context/title"> |
| 50 </td> | 50 </td> |
| 51 </tr> | 51 </tr> |
| 52 | 52 |
| 53 <tr> | 53 <tr> |