Mercurial > p > roundup > code
comparison roundup/cgi/wsgi_handler.py @ 8465:617d55f1d518
refactor: replace boolean expr with named function call
Replace a confusing boolean expression with a the use_cached_tracker()
method call.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 11 Oct 2025 18:18:54 -0400 |
| parents | 14c7c07b32d8 |
| children | b09ef85f0da6 |
comparison
equal
deleted
inserted
replaced
| 8464:72f549e68534 | 8465:617d55f1d518 |
|---|---|
| 95 lang, | 95 lang, |
| 96 tracker_home=home) | 96 tracker_home=home) |
| 97 else: | 97 else: |
| 98 self.translator = None | 98 self.translator = None |
| 99 | 99 |
| 100 if "cache_tracker" not in self.feature_flags or \ | 100 if self.use_cached_tracker(): |
| 101 self.feature_flags["cache_tracker"] is not False: | |
| 102 self.tracker = roundup.instance.open(self.home, not self.debug) | 101 self.tracker = roundup.instance.open(self.home, not self.debug) |
| 103 else: | 102 else: |
| 104 self.preload() | 103 self.preload() |
| 104 | |
| 105 def use_cached_tracker(self): | |
| 106 return ( | |
| 107 "cache_tracker" not in self.feature_flags or | |
| 108 self.feature_flags["cache_tracker"] is not False) | |
| 105 | 109 |
| 106 @gen_trace_id() | 110 @gen_trace_id() |
| 107 @store_trace_reason("wsgi") | 111 @store_trace_reason("wsgi") |
| 108 def __call__(self, environ, start_response): | 112 def __call__(self, environ, start_response): |
| 109 """Initialize with `apache.Request` object""" | 113 """Initialize with `apache.Request` object""" |
| 133 # form. | 137 # form. |
| 134 form = None | 138 form = None |
| 135 else: | 139 else: |
| 136 form = BinaryFieldStorage(fp=environ['wsgi.input'], environ=environ) | 140 form = BinaryFieldStorage(fp=environ['wsgi.input'], environ=environ) |
| 137 | 141 |
| 138 if "cache_tracker" not in self.feature_flags or \ | 142 if self.use_cached_tracker(): |
| 139 self.feature_flags["cache_tracker"] is not False: | |
| 140 client = self.tracker.Client(self.tracker, request, environ, form, | 143 client = self.tracker.Client(self.tracker, request, environ, form, |
| 141 self.translator) | 144 self.translator) |
| 142 try: | 145 try: |
| 143 client.main() | 146 client.main() |
| 144 except roundup.cgi.client.NotFound: | 147 except roundup.cgi.client.NotFound: |