Mercurial > p > roundup > code
comparison roundup/roundupdb.py @ 7211:506c86823abb
Add config argument to more password.Password invocations.
The work done to allow password_pbkdf2_default_rounds to be overridden
for testing requires that calls to password.Password include a config
argument.
This was needed because using the real value more than quadrupled
testing runtime.
However there are still a few places where config was not being set
when Password was called. I think this fixes all of the ones that are
called from a function that have access to a db.config object.
The remaining ones all call Password(encrypted=x). This results in
Password.unpack() being called. If x is not a propertly formatted
password string ("{scheme}...", it calls encodePassword. It then
should end up raising the ConfigNotSet exception. This is
probably what we want as it means the shape of "x" is not correct.
I don't understand why Password.unpack() attempts to encrypt the value
of encrypted if it doesn't match the right form. According to codecov,
this encryption branch is being used, so somewhere x is of the wrong
form. Hmmm....
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 04 Mar 2023 00:17:26 -0500 |
| parents | ff879aa00987 |
| children | 2b0089104f08 |
comparison
equal
deleted
inserted
replaced
| 7210:7147a4c833e9 | 7211:506c86823abb |
|---|---|
| 112 elif isinstance(proptype, hyperdb.Date): | 112 elif isinstance(proptype, hyperdb.Date): |
| 113 props[propname] = date.Date(value) | 113 props[propname] = date.Date(value) |
| 114 elif isinstance(proptype, hyperdb.Interval): | 114 elif isinstance(proptype, hyperdb.Interval): |
| 115 props[propname] = date.Interval(value) | 115 props[propname] = date.Interval(value) |
| 116 elif isinstance(proptype, hyperdb.Password): | 116 elif isinstance(proptype, hyperdb.Password): |
| 117 props[propname] = password.Password(encrypted=value) | 117 props[propname] = password.Password(encrypted=value, |
| 118 config=self.config) | |
| 118 | 119 |
| 119 # tag new user creation with 'admin' | 120 # tag new user creation with 'admin' |
| 120 self.journaltag = 'admin' | 121 self.journaltag = 'admin' |
| 121 | 122 |
| 122 # create the new user | 123 # create the new user |