comparison doc/design.txt @ 5232:462b0f76fce8

issue2550864 - Potential information leakage via journal/history Fix this by making the hyperdb::Class::history function check for view permissions on the journaled properties. So a user that sees [hidden] for a property in the web interface doesn;t see the property changes in the history. While doing this, relocated the filter for quiet properties from the templating class to the hyperdb. Also added the skipquiet option to the history command in roundup-admin.py to enable filtering of quiet params. Also changed calls to history() in the backend databases to report all items. Changed inline documentation for all history calls that document the actions. The create action (before nov 6 2002) used to record all parameters. After that point the create call uses an empty dictionary. The filtering code depends on the create dictionary being empty. It may not operate properly on very old roundup databases. Changed calls to logging.getLogger to roundup.hyperdb.backends to allow filtering the back end while keeping hyperdb logging. In cgi/templating.py, changed history() function consolidating handiling of link and unlink actions Added tests for quiet property filtering and permission filtering of history.
author John Rouillard <rouilj@ieee.org>
date Fri, 14 Apr 2017 23:24:18 -0400
parents 8901cc4ef0e0
children 15440504fb04
comparison
equal deleted inserted replaced
5231:8743b7226dc7 5232:462b0f76fce8
284 title=String(required=True, default_value="not set",quiet=True) 284 title=String(required=True, default_value="not set",quiet=True)
285 285
286 will create a property called ``title`` that will be included in the 286 will create a property called ``title`` that will be included in the
287 get_required_props() output. Calling 287 get_required_props() output. Calling
288 db.issue.properties['title'].get_default_value() will return "not set". 288 db.issue.properties['title'].get_default_value() will return "not set".
289 Changes to the property will not be displayed in emailed change notes, 289 Changes to the property will not be displayed in:
290 the history at the end of the item pages in the web interface and will 290
291 be suppressed in the confirmation notice (displayed as a green banner) 291 - emailed change notes,
292 shown on changes. 292 - the history at the end of the item pages in the web interface
293 - in the confirmation notice (displayed as a green banner)
294 shown on changes.
293 295
294 These objects are used when specifying what properties belong in classes:: 296 These objects are used when specifying what properties belong in classes::
295 297
296 class String: 298 class String:
297 def __init__(self, indexme='no'): 299 def __init__(self, indexme='no'):

Roundup Issue Tracker: http://roundup-tracker.org/