Mercurial > p > roundup > code
comparison CHANGES.txt @ 8265:35beff316883
fix(api): issue2551384. Verify REST authorization earlier
To reduce the ability of bad actors to spam (DOS) the REST endpoint
with bad data and generate logs meant for debugging, modify the flow
in client.py's REST handler to verify authorization earlier.
If the anonymous user is allowed to use REST, this won't make a
difference for a DOS attempt. The templates don't enable REST for the
anonymous user by default. Most admins don't change this.
The validation order for REST requests has been changed.
CORS identfied an handled
User authorization to use REST (return 403 on failure)
REST request validated (Origin header valid etc.) (return 400 for
bad request)
Incorrectly formatted CORS preflight requests (e.g. missing Origin
header) that are not recogized as a CORS request can now return HTTP
status 403 as well as status 400 (when anonymous is allowed
access). Note all CORS preflights are sent without authentication so
appear as anonymous requests.
The tests were updated to compensate, but it is not obvious to me from
specs what the proper evaulation order/return codes should be for this
case. Both 403/400 are failures and cause CORS to fail so there should
be no difference but...
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 09 Jan 2025 09:30:08 -0500 |
| parents | 2a7c3eeaf167 |
| children | 05d8806b25ad |
comparison
equal
deleted
inserted
replaced
| 8264:09e8d1a4c796 | 8265:35beff316883 |
|---|---|
| 58 it the default. (John Rouillard) | 58 it the default. (John Rouillard) |
| 59 - fixed a crash with roundup-admin perftest password when rounds not set | 59 - fixed a crash with roundup-admin perftest password when rounds not set |
| 60 on command line. (John Rouillard) | 60 on command line. (John Rouillard) |
| 61 - issue2551374 - Add error handling for filter expressions. Filter | 61 - issue2551374 - Add error handling for filter expressions. Filter |
| 62 expression errors are now reported. (John Rouillard) | 62 expression errors are now reported. (John Rouillard) |
| 63 - issue2551384: Modify flow in client.py's REST handler to verify | |
| 64 authorization earlier. The validation order for REST requests | |
| 65 has been changed. Checking user authorization to use the REST | |
| 66 interface is done before validating the Origin header. As a | |
| 67 result, incorrectly formatted CORS preflight requests | |
| 68 (e.g. missing Origin header) can now return HTTP status 403 as | |
| 69 well as status 400. (John Rouillard) | |
| 63 | 70 |
| 64 Features: | 71 Features: |
| 65 | 72 |
| 66 - issue2551287 - Enhance roundup_gettext.py to extract strings from | 73 - issue2551287 - Enhance roundup_gettext.py to extract strings from |
| 67 detectors/extensions. If the polib module is available, | 74 detectors/extensions. If the polib module is available, |
