Mercurial > p > roundup > code
comparison roundup/cgi/actions.py @ 5251:35b30ce991d0
Suppress the "... - nothing changed" status banner presented when a
form is submitted. This is triggered only when only quiet properties
are changed.
See:
https://sourceforge.net/p/roundup/mailman/roundup-users/thread/20170421012107.E040180690%40vm71.cs.umb.edu/
with subject:
[Roundup-users] Does anybody think feedback saying "nothing changed" is useful?
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 10 Aug 2017 22:35:05 -0400 |
| parents | 17b213eab274 |
| children | 28b6bfd303c3 |
comparison
equal
deleted
inserted
replaced
| 5241:092c4522b3bf | 5251:35b30ce991d0 |
|---|---|
| 631 info = ', '.join(map(self._, props)) | 631 info = ', '.join(map(self._, props)) |
| 632 m.append( | 632 m.append( |
| 633 self._('%(class)s %(id)s %(properties)s edited ok') | 633 self._('%(class)s %(id)s %(properties)s edited ok') |
| 634 % {'class':cn, 'id':nodeid, 'properties':info}) | 634 % {'class':cn, 'id':nodeid, 'properties':info}) |
| 635 else: | 635 else: |
| 636 m.append(self._('%(class)s %(id)s - nothing changed') | 636 # this used to produce a message like: |
| 637 % {'class':cn, 'id':nodeid}) | 637 # issue34 - nothing changed |
| 638 # which is confusing if only quiet properties | |
| 639 # changed for the class/id. So don't report | |
| 640 # anything is the user didn't explicitly change | |
| 641 # a visible (non-quiet) property. | |
| 642 pass | |
| 638 else: | 643 else: |
| 639 assert props | 644 assert props |
| 640 | 645 |
| 641 # make a new node | 646 # make a new node |
| 642 newid = self._createnode(cn, props) | 647 newid = self._createnode(cn, props) |